-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replay not saved during animations #2518
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2518 +/- ##
==========================================
+ Coverage 87.01% 91.62% +4.60%
==========================================
Files 265 88 -177
Lines 9426 3079 -6347
==========================================
- Hits 8202 2821 -5381
+ Misses 1224 258 -966 ☔ View full report in Codecov by Sentry. |
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
691aa3b | 370.43 ms | 466.28 ms | 95.85 ms |
8f95e33 | 444.80 ms | 493.21 ms | 48.42 ms |
29297d4 | 377.14 ms | 451.54 ms | 74.40 ms |
039058a | 448.52 ms | 512.55 ms | 64.03 ms |
2f8f173 | 323.31 ms | 373.29 ms | 49.97 ms |
48c3cf1 | 491.55 ms | 541.64 ms | 50.09 ms |
294b7f0 | 367.83 ms | 430.00 ms | 62.17 ms |
178baee | 421.59 ms | 522.28 ms | 100.69 ms |
7faee57 | 372.19 ms | 443.08 ms | 70.90 ms |
6572f8d | 302.35 ms | 348.10 ms | 45.75 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
691aa3b | 5.94 MiB | 6.96 MiB | 1.02 MiB |
8f95e33 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
29297d4 | 6.34 MiB | 7.28 MiB | 967.79 KiB |
039058a | 6.52 MiB | 7.59 MiB | 1.06 MiB |
2f8f173 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
48c3cf1 | 6.49 MiB | 7.55 MiB | 1.07 MiB |
294b7f0 | 6.33 MiB | 7.26 MiB | 950.21 KiB |
178baee | 6.35 MiB | 7.42 MiB | 1.07 MiB |
7faee57 | 6.35 MiB | 7.40 MiB | 1.05 MiB |
6572f8d | 6.15 MiB | 7.13 MiB | 999.97 KiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6d50a9b | 1225.69 ms | 1233.94 ms | 8.25 ms |
33d0587 | 1262.16 ms | 1270.50 ms | 8.34 ms |
9f05645 | 1236.65 ms | 1253.11 ms | 16.45 ms |
7f75f32 | 1230.80 ms | 1251.79 ms | 20.99 ms |
7f2b01d | 1253.92 ms | 1266.70 ms | 12.78 ms |
2b9937e | 1226.27 ms | 1265.18 ms | 38.91 ms |
a1a1545 | 1270.85 ms | 1289.82 ms | 18.96 ms |
4656f10 | 1247.04 ms | 1276.16 ms | 29.12 ms |
8d64376 | 1260.92 ms | 1289.32 ms | 28.40 ms |
280ab9f | 1255.71 ms | 1262.78 ms | 7.06 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6d50a9b | 8.38 MiB | 9.74 MiB | 1.36 MiB |
33d0587 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
9f05645 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
7f75f32 | 8.28 MiB | 9.33 MiB | 1.05 MiB |
7f2b01d | 8.16 MiB | 9.16 MiB | 1.00 MiB |
2b9937e | 8.38 MiB | 9.78 MiB | 1.40 MiB |
a1a1545 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
4656f10 | 8.32 MiB | 9.50 MiB | 1.19 MiB |
8d64376 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
280ab9f | 8.29 MiB | 9.39 MiB | 1.10 MiB |
📜 Description
In a recent PR, I've changed the screenshot processing to run between frames (scheduling for when the app is idle). This breaks when there's a continuous animation on the page, e.g. a loader. Rolling this back so it runs as before.
#skip-changelog because nothing shipped yet.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps