Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup update-android.sh #2047

Merged
merged 1 commit into from
May 12, 2024
Merged

fixup update-android.sh #2047

merged 1 commit into from
May 12, 2024

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented May 10, 2024

this line got here by accident from another PR

#skip-changelog

  this line got here by accident from another pR
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (4fe92c5) to head (2f528aa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2047   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files          54       54           
  Lines        1788     1788           
=======================================
  Hits         1704     1704           
  Misses         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 370.37 ms 453.70 ms 83.33 ms
Size 6.33 MiB 7.30 MiB 992.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2d3b03d 309.53 ms 353.40 ms 43.87 ms
3500574 288.69 ms 358.34 ms 69.65 ms
a2ec542 322.27 ms 372.87 ms 50.60 ms
42f6e7e 308.71 ms 360.06 ms 51.35 ms
f1314d5 313.89 ms 372.10 ms 58.21 ms
4b943a1 348.17 ms 437.15 ms 88.98 ms
6078ddc 385.72 ms 463.61 ms 77.89 ms
5d2b46d 307.74 ms 349.85 ms 42.11 ms
aa950e9 337.42 ms 400.72 ms 63.30 ms
74e1fdd 398.61 ms 418.43 ms 19.82 ms

App size

Revision Plain With Sentry Diff
2d3b03d 6.06 MiB 7.09 MiB 1.03 MiB
3500574 6.16 MiB 7.14 MiB 1009.90 KiB
a2ec542 6.06 MiB 7.10 MiB 1.04 MiB
42f6e7e 6.27 MiB 7.20 MiB 956.06 KiB
f1314d5 6.06 MiB 7.10 MiB 1.04 MiB
4b943a1 6.34 MiB 7.28 MiB 968.41 KiB
6078ddc 6.34 MiB 7.29 MiB 967.80 KiB
5d2b46d 6.16 MiB 7.13 MiB 1000.82 KiB
aa950e9 5.94 MiB 6.96 MiB 1.02 MiB
74e1fdd 6.33 MiB 7.27 MiB 954.12 KiB

Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1250.45 ms 1265.56 ms 15.11 ms
Size 8.32 MiB 9.52 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fbf42af 1253.76 ms 1269.51 ms 15.76 ms
f6f3d25 1253.80 ms 1258.39 ms 4.59 ms
7e30648 1241.43 ms 1255.76 ms 14.33 ms
c1bb00f 1265.14 ms 1290.85 ms 25.71 ms
3de8b9b 1234.22 ms 1251.94 ms 17.72 ms
1e094d3 1237.54 ms 1243.51 ms 5.97 ms
f4cc744 1274.57 ms 1290.79 ms 16.22 ms
29297d4 1245.82 ms 1276.57 ms 30.76 ms
21562c5 1235.43 ms 1254.00 ms 18.57 ms
3e33891 6245.86 ms 6260.90 ms 15.04 ms

App size

Revision Plain With Sentry Diff
fbf42af 8.16 MiB 9.17 MiB 1.01 MiB
f6f3d25 8.28 MiB 9.34 MiB 1.06 MiB
7e30648 8.29 MiB 9.36 MiB 1.07 MiB
c1bb00f 8.09 MiB 9.07 MiB 1001.06 KiB
3de8b9b 8.28 MiB 9.34 MiB 1.06 MiB
1e094d3 8.29 MiB 9.37 MiB 1.08 MiB
f4cc744 8.16 MiB 9.16 MiB 1.01 MiB
29297d4 8.33 MiB 9.40 MiB 1.07 MiB
21562c5 8.29 MiB 9.36 MiB 1.07 MiB
3e33891 8.29 MiB 9.38 MiB 1.09 MiB

@vaind vaind merged commit 0f067d3 into main May 12, 2024
48 checks passed
@vaind vaind deleted the vaind-patch-1 branch May 12, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants