-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App start: Create transaction when no SentryNavigatorObserver
is present
#2017
Merged
Merged
Changes from 44 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
5ad308b
commit
buenaflor 7bc756b
Merge branch 'main' into feat/app-start-improve
buenaflor 3e0790a
Update
buenaflor d0eb540
Remove print
buenaflor 05c208c
Remove comments
buenaflor c796b71
Update
buenaflor da8297e
Merge branch 'main' into feat/app-start-improve
buenaflor bdc8588
Add linting
buenaflor d1b37cd
Update CHANGELOG
buenaflor 6f44478
Update CHANGELOG.md
buenaflor 8051972
Update naming
buenaflor 29671ff
Merge branch 'main' into feat/app-start-improve
buenaflor b401ed0
Update naming
buenaflor c06973c
Update naming
buenaflor 8b9c0c0
Create transaction
buenaflor 2bb3887
Update description from first frame render to initial frame render
buenaflor 85e851b
Merge branch 'feat/app-start-improve' into feat/app-start-improve-2
buenaflor 58f2585
Update
buenaflor 801483e
update
buenaflor d28af71
dart format
buenaflor 21c61a6
Update comments
buenaflor 88a8819
Update
buenaflor 0d73052
Update
buenaflor 1e05ae5
Update
buenaflor 73d830a
Update
buenaflor 62cb2be
Update
buenaflor 111125c
Fix tests
buenaflor 04ad023
Fix test
buenaflor e9e95c4
Add unused import
buenaflor ce7af57
Merge branch 'feat/app-start-improve' into feat/app-start-improve-2
buenaflor 615782e
Update
buenaflor 04724d5
Update
buenaflor 263c020
Updat
buenaflor f7573f1
Fix tests
buenaflor 3a9cca9
Fix tests
buenaflor 5fff0be
Merge branch 'main' into feat/app-start-improve-2
buenaflor 26e5834
Fix analyze
buenaflor b0f49c5
Merge branch 'main' into feat/app-start-improve-2
buenaflor 37b6771
Update
buenaflor 06836a2
Update
buenaflor 8984d63
Merge branch 'main' into feat/app-start-improve-2
buenaflor e294533
Updaet
buenaflor eb90496
Merge branch 'main' into feat/app-start-improve-2
buenaflor 7001b46
Update
buenaflor 0063429
Add additional flag and update comment
buenaflor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could even have an additional static flag
isAttached
that is set to true when the class is instantiated, and use it together with this check, but not sure if that would actually help some case.Your call here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm I think it would be good to have it additionally, I'll add it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think naming it something like
isCreated
is more accurate since you can also instantiate it earlier and attach it much later