Testflight

[denrase]

#skip-changelog

📜 Description

Setup an action to upload the iOS sample app to TestFlight.

💡 Motivation and Context

Closes #387

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
• I updated the docs if needed
• All tests passing
• No breaking changes

🔮 Next steps

• Don't run action on PR push
• Since we bumped to iOS 12, we need to wait for v8 to merge this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (1ac008b) to head (b8bf06c).
Report is 45 commits behind head on main.

❗ Current head b8bf06c differs from pull request most recent head 28f358c. Consider uploading reports for the commit 28f358c to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
+ Coverage   88.57%   92.02%   +3.45%     
==========================================
  Files         207       51     -156     
  Lines        6897     1656    -5241     
==========================================
- Hits         6109     1524    -4585     
+ Misses        788      132     -656     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 28f358c

[github-actions]

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	395.00 ms	467.06 ms	72.06 ms
Size	6.34 MiB	7.28 MiB	967.79 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
d089990	361.67 ms	442.50 ms	80.83 ms
3637a22	322.59 ms	390.00 ms	67.41 ms
8e4eeb3	365.78 ms	435.58 ms	69.80 ms
4829ad3	381.55 ms	455.45 ms	73.90 ms
25161f4	353.98 ms	431.94 ms	77.96 ms
1cdcacf	389.94 ms	463.53 ms	73.59 ms
6325c3b	339.33 ms	409.86 ms	70.53 ms
633cf2e	289.36 ms	340.38 ms	51.02 ms
3f23617	385.77 ms	476.10 ms	90.33 ms
26e955b	369.52 ms	458.60 ms	89.07 ms

App size

Revision	Plain	With Sentry	Diff
d089990	6.34 MiB	7.28 MiB	967.79 KiB
3637a22	6.06 MiB	7.09 MiB	1.03 MiB
8e4eeb3	6.33 MiB	7.27 MiB	954.12 KiB
4829ad3	6.33 MiB	7.26 MiB	943.11 KiB
25161f4	6.27 MiB	7.20 MiB	960.44 KiB
1cdcacf	6.33 MiB	7.26 MiB	949.77 KiB
6325c3b	5.94 MiB	6.96 MiB	1.02 MiB
633cf2e	5.94 MiB	6.92 MiB	1001.53 KiB
3f23617	5.94 MiB	6.96 MiB	1.02 MiB
26e955b	6.27 MiB	7.20 MiB	956.49 KiB

Previous results on branch: feat/testflight

Startup times

Revision	Plain	With Sentry	Diff
a5b1805	387.06 ms	461.12 ms	74.06 ms
082c35b	372.76 ms	442.91 ms	70.16 ms
58fe2b8	402.09 ms	500.39 ms	98.30 ms
6bf3287	353.15 ms	431.42 ms	78.26 ms
67ae3ad	596.28 ms	698.90 ms	102.62 ms
dde7173	370.60 ms	434.38 ms	63.78 ms
bb8f7e6	343.82 ms	415.86 ms	72.04 ms
1c2d2ce	398.74 ms	460.83 ms	62.09 ms
9532935	361.90 ms	437.67 ms	75.78 ms
b8bf06c	400.83 ms	491.73 ms	90.90 ms

App size

Revision	Plain	With Sentry	Diff
a5b1805	6.34 MiB	7.28 MiB	963.21 KiB
082c35b	6.33 MiB	7.27 MiB	954.12 KiB
58fe2b8	6.33 MiB	7.27 MiB	954.12 KiB
6bf3287	6.33 MiB	7.27 MiB	954.12 KiB
67ae3ad	6.34 MiB	7.28 MiB	963.21 KiB
dde7173	6.34 MiB	7.28 MiB	967.79 KiB
bb8f7e6	6.33 MiB	7.27 MiB	954.11 KiB
1c2d2ce	6.34 MiB	7.28 MiB	967.80 KiB
9532935	6.33 MiB	7.27 MiB	954.02 KiB
b8bf06c	6.33 MiB	7.27 MiB	954.12 KiB

[github-actions]

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1366.90 ms	1415.80 ms	48.91 ms
Size	8.33 MiB	9.40 MiB	1.07 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
1c6eb5b	1277.85 ms	1285.71 ms	7.86 ms
8609bd8	1267.16 ms	1291.39 ms	24.22 ms
d7758e8	1271.69 ms	1288.08 ms	16.39 ms
cd16818	1254.78 ms	1267.76 ms	12.98 ms
2d74010	1264.45 ms	1268.42 ms	3.97 ms
ecb4003	1266.94 ms	1290.24 ms	23.31 ms
6325c3b	1266.52 ms	1291.06 ms	24.54 ms
08a7b4f	1277.10 ms	1303.37 ms	26.27 ms
deaeece	1252.82 ms	1279.04 ms	26.22 ms
aed5947	1268.67 ms	1281.10 ms	12.43 ms

App size

Revision	Plain	With Sentry	Diff
1c6eb5b	8.15 MiB	9.12 MiB	986.27 KiB
8609bd8	8.28 MiB	9.34 MiB	1.06 MiB
d7758e8	8.15 MiB	9.12 MiB	989.76 KiB
cd16818	8.28 MiB	9.33 MiB	1.05 MiB
2d74010	8.32 MiB	9.38 MiB	1.05 MiB
ecb4003	8.09 MiB	9.07 MiB	1000.82 KiB
6325c3b	8.16 MiB	9.17 MiB	1.01 MiB
08a7b4f	8.16 MiB	9.16 MiB	1.01 MiB
deaeece	8.16 MiB	9.17 MiB	1.01 MiB
aed5947	8.16 MiB	9.17 MiB	1.01 MiB

Previous results on branch: feat/testflight

Startup times

Revision	Plain	With Sentry	Diff
5477a5d	1209.88 ms	1229.16 ms	19.29 ms
a073cc9	1210.20 ms	1226.29 ms	16.08 ms
58fe2b8	1226.98 ms	1252.48 ms	25.50 ms
1c2d2ce	1225.29 ms	1251.00 ms	25.71 ms
9532935	1208.14 ms	1235.69 ms	27.55 ms
67cf1e5	1248.20 ms	1268.83 ms	20.63 ms
a5b1805	1211.12 ms	1224.59 ms	13.47 ms
67ae3ad	1201.59 ms	1225.92 ms	24.33 ms
6d62732	1221.82 ms	1229.33 ms	7.52 ms
dde7173	1250.04 ms	1274.35 ms	24.31 ms

App size

Revision	Plain	With Sentry	Diff
5477a5d	8.33 MiB	9.39 MiB	1.06 MiB
a073cc9	8.32 MiB	9.38 MiB	1.06 MiB
58fe2b8	8.32 MiB	9.38 MiB	1.06 MiB
1c2d2ce	8.33 MiB	9.40 MiB	1.07 MiB
9532935	8.32 MiB	9.38 MiB	1.06 MiB
67cf1e5	8.32 MiB	9.38 MiB	1.06 MiB
a5b1805	8.33 MiB	9.39 MiB	1.06 MiB
67ae3ad	8.33 MiB	9.39 MiB	1.06 MiB
6d62732	8.33 MiB	9.39 MiB	1.06 MiB
dde7173	8.33 MiB	9.40 MiB	1.07 MiB

[denrase]

@kahest @buenaflor We need to create the app in AppStore Connect, add a provisioning profile to the match repo, and add the secrets to the repository that we also have in the sentry-cocoa repo so we can upload the build. I don't have permission to do any of these.

[getsantry]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[denrase]

• Provisioning profile needs to be created in the match repo.
• Someone with permissions needs to check if all secrets are set in the repository.

[kahest]

@denrase thanks! secrets are set

[denrase]

@kahest @buenaflor We need to add the push notification capability to the provisioning profile and update it in the match repo.

[denrase]

@buenaflor Any update here?

[denrase]

@buenaflor The PP works now, thank you! I think we have one more issue. I guess the token we use here is missing a permission?

☑ uploading source maps                                                             

INFO    2024-02-20 14:54:09.615728 +00:00 sentry-cli was invoked with the following command line: "/Users/runner/work/sentry-dart/sentry-dart/flutter/example/.dart_tool/pub/bin/sentry_dart_plugin/sentry-cli" "--log-level" "info" "releases" "--org" "sentry-sdks" "--project" "sentry-flutter" "set-commits" "[email protected]" "--auto" "--ignore-missing"

error: API request failed
  caused by: sentry reported an error: You do not have permission to perform this action. (http status: 403)

exitCode: 1

[denrase]

• Disable source mode uploads to check if this a sentry issue

[buenaflor]

Is this intentional? since we updated the min version to 12 in v8

[denrase]

I will try again if building/ci works with 11

[denrase]

Only wirks with v12. I created a new PR based on the V8 branch.

[denrase]

Closed in favour of #1938