Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/more protocol #155

Merged
merged 53 commits into from
Nov 9, 2020
Merged

Feat/more protocol #155

merged 53 commits into from
Nov 9, 2020

Conversation

rxlabz
Copy link
Contributor

@rxlabz rxlabz commented Oct 30, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

complete the Sentry protocol :

  • add classes : Request, DebugMeta, DebugImage,...
  • add SentryException and SentryStacktrace factories
  • add inApp excludes and includes logic

💡 Motivation and Context

https://develop.sentry.dev/sdk/unified-api/

💚 How did you test it?

mostly added tests to exception serialization, factories and precedence

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

rxlabz added 3 commits November 3, 2020 10:06
@rxlabz
feedbacks
93b98bc
@rxlabz
event throwable & stacktrace
8dd353f
@rxlabz
- add a default stacktrace factory
f84b1ec 
- add origin to stackFrame serialization
- fix tests
- fix flutter example
marandaneto
marandaneto reviewed Nov 4, 2020
View reviewed changes
@rxlabz rxlabz marked this pull request as ready for review November 9, 2020 11:48
@rxlabz rxlabz requested a review from bruno-garcia as a code owner November 9, 2020 11:48
marandaneto
marandaneto reviewed Nov 9, 2020
View reviewed changes
dart/lib/src/protocol/sentry_event.dart Outdated
import '../utils.dart';
import '../version.dart';
import 'request.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be automatically imported by '../protocol.dart';?

@marandaneto marandaneto merged commit 61271f7 into main Nov 9, 2020
@marandaneto marandaneto deleted the feat/more-protocol branch November 9, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto left review comments

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rxlabz @marandaneto