unified fixes #148
unified fixes #148
Conversation
dart/lib/src/sentry_client.dart
Outdated
| @@ -22,7 +22,13 @@ abstract class SentryClient { | |||
| SentryClient.base(this._options, {String origin}) { | |||
| _random = _options.sampleRate == null ? null : Random(); | |||
| if (_options.transport is NoOpTransport) { | |||
| _options.transport = HttpTransport(options: _options, origin: origin); | |||
There was a problem hiding this comment.
@marandaneto shouldn't we catch the potential Dns.parse exception ? What do you think would be the best strategy or preferred wording here ?
There was a problem hiding this comment.
on Java we do on Sentry.init
ideally, we try to parse on https://github.com/getsentry/sentry-dart/blob/feature/unified-api/dart/lib/src/sentry.dart#L112-L121
so we crash on Sentry.init and people can fix right away
| // origin is necessary for sentry to resolve stacktrace | ||
| return SentryBrowserClient._(options); | ||
| } | ||
| factory SentryBrowserClient(SentryOptions options) => |
There was a problem hiding this comment.
make me wonder if now we need to have a SentryBrowserClient and IOClient only because of the origin field.
There was a problem hiding this comment.
true, we could move the origin settings in transport, and use the same strategy as for gzip compression => it will remove the need for 2 clients
📢 Type of change
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps