Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore : analysis options #143

Merged
merged 2 commits into from
Oct 27, 2020
Merged

chore : analysis options #143

merged 2 commits into from
Oct 27, 2020

Conversation

rxlabz
Copy link
Contributor

@rxlabz rxlabz commented Oct 27, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Stricter analysis options :

  • prefer relative path
  • error missing @required argument
    ...

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@rxlabz rxlabz changed the title lint : prefer relative imports and show error when a @required argume… chore : analysis options Oct 27, 2020
marandaneto
marandaneto approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this, LGTM

@marandaneto marandaneto merged commit a0bb939 into feature/unified-api Oct 27, 2020
@marandaneto marandaneto deleted the chore/analysis-options branch October 27, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rxlabz @marandaneto