-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to Gradle 8+ #1427
Add support to Gradle 8+ #1427
Conversation
@marandaneto @davidmartos96 Maybe an integration test to check that the plugin builds with Gradle 7 and 8 would make sense to add? |
@krystofwoldrich Is there any test of that kind in the repo? I'm not sure how it would work or if it would be worth the effort. This change is equivalent to the one the official plugins have recently pushed in latest versions. |
1 similar comment
@krystofwoldrich Is there any test of that kind in the repo? I'm not sure how it would work or if it would be worth the effort. This change is equivalent to the one the official plugins have recently pushed in latest versions. |
Since we don't use AGP 8 yet, this is an integration test per see :) |
Thanks @davidmartos96 |
@davidmartos96 can you add a changelog entry? https://github.com/getsentry/sentry-dart/blob/main/CHANGELOG.md#fixes |
@marandaneto Done! |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 181 181
Lines 5788 5788
=======================================
Hits 5223 5223
Misses 565 565 ☔ View full report in Codecov by Sentry. |
📜 Description
Hello, currently the plugin doesn't build when Gradle 8+ is used. That is because the property
namespace
is mandatory.📝 Checklist
sendDefaultPii
is enabled