Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref/file names #141

Merged
merged 5 commits into from
Oct 27, 2020
Merged

Ref/file names #141

merged 5 commits into from
Oct 27, 2020

Conversation

rxlabz
Copy link
Contributor

@rxlabz rxlabz commented Oct 27, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

rename files accordely to their content

💡 Motivation and Context

https://develop.sentry.dev/sdk/unified-api

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@rxlabz rxlabz marked this pull request as ready for review October 27, 2020 15:29
@@ -289,8 +289,7 @@ class SentryEvent {
}

Map<String, dynamic> userContextMap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be userMap only now

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is broken, but after fixing it is LGTM

@rxlabz rxlabz merged commit dc258d9 into feature/unified-api Oct 27, 2020
@rxlabz rxlabz deleted the ref/file_names branch October 27, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants