Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Breadcrumb data should accept serializable types and not only String values #139

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Fix: Breadcrumb data should accept serializable types and not only String values #139

merged 3 commits into from
Oct 26, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 26, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fix: Breadcrumb data should accept serializable types and not only String values

💡 Motivation and Context

https://develop.sentry.dev/sdk/event-payloads/breadcrumbs/
#129

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the title fix/breadcrumb data Fix: Breadcrumb data should accept serializable types and not only String values Oct 26, 2020
@marandaneto marandaneto requested a review from rxlabz October 26, 2020 11:11
@marandaneto marandaneto changed the base branch from main to feature/unified-api October 26, 2020 11:11
rxlabz
rxlabz reviewed Oct 26, 2020
View reviewed changes
rxlabz
rxlabz approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@rxlabz rxlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto @rxlabz
Update CHANGELOG.md
20ed605 
Co-authored-by: Erick Ghaumez <[email protected]>
@marandaneto marandaneto merged commit dc962ae into feature/unified-api Oct 26, 2020
@marandaneto marandaneto deleted the fix/breadcrumb-data branch October 26, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxlabz rxlabz rxlabz approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @rxlabz