Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: NoOp encode for Web #138

Merged
merged 4 commits into from
Oct 26, 2020
Merged

Fix: NoOp encode for Web #138

merged 4 commits into from
Oct 26, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 26, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fix: NoOp encode for Web

💡 Motivation and Context

NoOp only for gzipping so DRY

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the title fix/encode Fix: NoOp encode for Web Oct 26, 2020
@marandaneto marandaneto changed the base branch from main to feature/unified-api October 26, 2020 10:58
@marandaneto marandaneto requested a review from rxlabz October 26, 2020 10:58
Copy link
Contributor

@rxlabz rxlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ( note : if compressPayload is a param of the SentryOptions ctor; it should have true as default ctor value, I already changed it in my fix/unified PR )

@marandaneto
Copy link
Contributor Author

LGTM ( note : if compressPayload is a param of the SentryOptions ctor; it should have true as default ctor value, I already changed it in my fix/unified PR )

the ctor should be gone altogether, default values are set on the field declaration like:

bool compressPayload = true;

Remember, the ctor of SnetryOptions should be gone.

@marandaneto marandaneto merged commit b9cd68b into feature/unified-api Oct 26, 2020
@marandaneto marandaneto deleted the fix/encode branch October 26, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants