Fix/unified api fixes and web example #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart/examples/web_example/README.md
Outdated
|
|
||
| ```dart | ||
| pub get | ||
| webdev serve --release |
There was a problem hiding this comment.
What's webdev? should we propose installing that?
In the Flutter Web example I used python3 which should be installed on macOS and Linux OOTB: https://github.com/getsentry/sentry-dart/blob/main/flutter/example/run.sh#L54
Not true for Windows though. So maybe a comment:
Suggested change
| webdev serve --release | |
| # Serve the static files with your preferred dev static site server | |
| webdev serve --release |
There was a problem hiding this comment.
it's the Dart cli to run and build Dart web projects.
To be served from a static site server, the project needs to be build (webdev build ...) .
webdev serve is simplest/fastest way to run this example, so I just added a link to the webdev page.
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
Co-authored-by: Bruno Garcia <[email protected]>
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
Comment on lines
9
to
28
| transaction: '/example/app', | ||
| level: SentryLevel.warning, | ||
| tags: const <String, String>{'project-id': '7371'}, | ||
| extra: const <String, String>{'company-name': 'Dart Inc'}, | ||
| fingerprint: const <String>['example-dart'], | ||
| userContext: const User( | ||
| id: '800', | ||
| username: 'first-user', | ||
| email: '[email protected]', | ||
| ipAddress: '127.0.0.1', | ||
| extras: <String, String>{'first-sign-in': '2020-01-01'}), | ||
| breadcrumbs: [ | ||
| Breadcrumb( | ||
| message: 'UI Lifecycle', | ||
| timestamp: DateTime.now().toUtc(), | ||
| category: 'ui.lifecycle', | ||
| type: 'navigation', | ||
| data: {'screen': 'MainActivity', 'state': 'created'}, | ||
| level: SentryLevel.info) | ||
| ], |
There was a problem hiding this comment.
I moved back fields which are "merged" with scope
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
marandaneto
reviewed
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
💡 Motivation and Context
verify everything working correctly after the unified refactoring
💚 How did you test it?
📝 Checklist
🔮 Next steps