-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Web Example build due to min. Dart version #1299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1299 +/- ##
==========================================
+ Coverage 90.03% 90.75% +0.71%
==========================================
Files 110 144 +34
Lines 3483 4736 +1253
==========================================
+ Hits 3136 4298 +1162
- Misses 347 438 +91
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8fa3934 | 340.64 ms | 407.92 ms | 67.28 ms |
fbf42af | 323.04 ms | 365.09 ms | 42.04 ms |
21d4150 | 379.31 ms | 449.23 ms | 69.93 ms |
08a7b4f | 346.47 ms | 403.29 ms | 56.82 ms |
9811573 | 309.76 ms | 402.60 ms | 92.84 ms |
c70e01a | 331.04 ms | 401.46 ms | 70.42 ms |
48e79fd | 354.22 ms | 391.46 ms | 37.24 ms |
3637a22 | 322.59 ms | 390.00 ms | 67.41 ms |
4efee31 | 308.92 ms | 368.68 ms | 59.76 ms |
6d7a391 | 331.94 ms | 367.04 ms | 35.10 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8fa3934 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
fbf42af | 5.94 MiB | 6.96 MiB | 1.02 MiB |
21d4150 | 5.94 MiB | 6.97 MiB | 1.03 MiB |
08a7b4f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
9811573 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
c70e01a | 5.94 MiB | 6.97 MiB | 1.03 MiB |
48e79fd | 5.94 MiB | 6.95 MiB | 1.01 MiB |
3637a22 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
4efee31 | 5.94 MiB | 6.92 MiB | 1003.76 KiB |
6d7a391 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6e083bb | 1244.33 ms | 1264.60 ms | 20.26 ms |
deaeece | 1252.82 ms | 1279.04 ms | 26.22 ms |
c70e01a | 1273.00 ms | 1299.12 ms | 26.12 ms |
2d3b03d | 1258.19 ms | 1272.69 ms | 14.50 ms |
1edf30e | 1254.43 ms | 1272.82 ms | 18.39 ms |
7f2b01d | 1253.92 ms | 1266.70 ms | 12.78 ms |
3a69405 | 1292.84 ms | 1303.96 ms | 11.12 ms |
ef2f368 | 1259.12 ms | 1277.04 ms | 17.92 ms |
e5b744f | 1250.82 ms | 1284.46 ms | 33.64 ms |
5112c69 | 1272.76 ms | 1293.37 ms | 20.61 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6e083bb | 8.16 MiB | 9.17 MiB | 1.01 MiB |
deaeece | 8.16 MiB | 9.17 MiB | 1.01 MiB |
c70e01a | 8.16 MiB | 9.17 MiB | 1.01 MiB |
2d3b03d | 8.10 MiB | 9.07 MiB | 1000.83 KiB |
1edf30e | 8.16 MiB | 9.17 MiB | 1.01 MiB |
7f2b01d | 8.16 MiB | 9.16 MiB | 1.00 MiB |
3a69405 | 8.15 MiB | 9.15 MiB | 1018.56 KiB |
ef2f368 | 8.15 MiB | 9.10 MiB | 965.24 KiB |
e5b744f | 8.09 MiB | 9.07 MiB | 1001.19 KiB |
5112c69 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
📜 Description
Fix Web Example build due to min. Dart version
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps