Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref: execute before send callback #128

Merged
merged 3 commits into from
Oct 24, 2020
Merged

Ref: execute before send callback #128

merged 3 commits into from
Oct 24, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 23, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Ref: execute before send callback

💡 Motivation and Context

left over from #123

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the base branch from main to feature/unified-api October 23, 2020 17:34
@marandaneto marandaneto changed the title ref/execute before send Ref: execute before send callback Oct 23, 2020
@marandaneto marandaneto requested a review from rxlabz October 23, 2020 17:35
bruno-garcia
bruno-garcia approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit c301ec6 into feature/unified-api Oct 24, 2020
@marandaneto marandaneto deleted the ref/execute-before-send branch October 24, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@rxlabz rxlabz Awaiting requested review from rxlabz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @bruno-garcia