Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref: Sentry init with null and empty DSN and close method #126

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Ref: Sentry init with null and empty DSN and close method #126

merged 3 commits into from
Oct 22, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 22, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Ref: Sentry init with null and empty DSN and close method #126

💡 Motivation and Context

One should be able to pass an empty DSN and disable the SDK, also to close the SDK if needed

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the title ref/sentry init close Ref: Sentry init with null and empty DSN and close method Oct 22, 2020
@marandaneto marandaneto requested a review from rxlabz October 22, 2020 13:22
@marandaneto marandaneto changed the base branch from main to feature/unified-api October 22, 2020 13:22
rxlabz
rxlabz approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@rxlabz rxlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit ee737a2 into feature/unified-api Oct 22, 2020
@marandaneto marandaneto deleted the ref/sentry-init-close branch October 22, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxlabz rxlabz rxlabz approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @rxlabz