-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intl is now more version permissive #1247
Conversation
Codecov ReportBase: 89.03% // Head: 89.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
==========================================
+ Coverage 89.03% 89.72% +0.69%
==========================================
Files 45 155 +110
Lines 1550 5033 +3483
==========================================
+ Hits 1380 4516 +3136
- Misses 170 517 +347
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a1a1545 | 295.21 ms | 351.16 ms | 55.95 ms |
08a7b4f | 346.47 ms | 403.29 ms | 56.82 ms |
25e9b59 | 307.00 ms | 348.83 ms | 41.83 ms |
3f23617 | 385.77 ms | 476.10 ms | 90.33 ms |
21d4150 | 379.31 ms | 449.23 ms | 69.93 ms |
d7758e8 | 300.12 ms | 349.88 ms | 49.76 ms |
5603ab2 | 309.84 ms | 345.20 ms | 35.36 ms |
f922f8f | 332.31 ms | 374.67 ms | 42.37 ms |
1131914 | 317.90 ms | 361.58 ms | 43.69 ms |
9811573 | 309.76 ms | 402.60 ms | 92.84 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a1a1545 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
08a7b4f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
25e9b59 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
3f23617 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
21d4150 | 5.94 MiB | 6.97 MiB | 1.03 MiB |
d7758e8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
5603ab2 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
f922f8f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
1131914 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
9811573 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
deaeece | 1252.82 ms | 1279.04 ms | 26.22 ms |
613760b | 1263.10 ms | 1277.27 ms | 14.16 ms |
a609134 | 1254.50 ms | 1265.08 ms | 10.58 ms |
a510d1d | 1277.04 ms | 1291.57 ms | 14.53 ms |
8d64376 | 1260.92 ms | 1289.32 ms | 28.40 ms |
9928a74 | 1249.98 ms | 1269.08 ms | 19.10 ms |
3a69405 | 1292.84 ms | 1303.96 ms | 11.12 ms |
af2d175 | 1280.37 ms | 1282.24 ms | 1.88 ms |
691aa3b | 1265.57 ms | 1282.13 ms | 16.55 ms |
ef2f368 | 1259.12 ms | 1277.04 ms | 17.92 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
deaeece | 8.16 MiB | 9.17 MiB | 1.01 MiB |
613760b | 8.15 MiB | 9.13 MiB | 1000.46 KiB |
a609134 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
a510d1d | 8.16 MiB | 9.17 MiB | 1.01 MiB |
8d64376 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
9928a74 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
3a69405 | 8.15 MiB | 9.15 MiB | 1018.56 KiB |
af2d175 | 8.15 MiB | 9.12 MiB | 986.22 KiB |
691aa3b | 8.16 MiB | 9.17 MiB | 1.01 MiB |
ef2f368 | 8.15 MiB | 9.10 MiB | 965.24 KiB |
📜 Description
pub has an addendun to sem ver and 0.x versions can be not compatible, using the
> and <
for now solves the problem, but we'd work on #1241 next.💡 Motivation and Context
#1202 and dart-lang/pub#3747
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
#1241