Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref: Hint is passed across Sentry static class, Hub and Client #124

Merged
merged 5 commits into from
Oct 22, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 22, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Ref: Hint is passed across Sentry static class, Hub and Client

💡 Motivation and Context

EventProcessors support Hint, in order to support that, Sentry static class, hub and Client should be able to get it

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the base branch from main to feature/unified-api October 22, 2020 08:11
@marandaneto marandaneto requested a review from rxlabz October 22, 2020 08:11
@marandaneto marandaneto changed the title ref/hint Ref: Hint is passed across Sentry static class, Hub and Client Oct 22, 2020
@@ -99,6 +99,7 @@ abstract class SentryClient {
SentryEvent event, {
StackFrameFilter stackFrameFilter,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@rxlabz rxlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (beside missing trailing comma :) )

@marandaneto marandaneto merged commit 2cc1d78 into feature/unified-api Oct 22, 2020
@marandaneto marandaneto deleted the ref/hint branch October 22, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants