Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Event now is SentryEvent and added GPU #121

Merged
merged 4 commits into from
Oct 22, 2020
Merged

ref: Event now is SentryEvent and added GPU #121

merged 4 commits into from
Oct 22, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 21, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

ref: Event now is SentryEvent and added GPU

💡 Motivation and Context

SDKs call an event as SentryEvent, loggerName is now logger, timestamp should be Event's timestamp, added missing GPU

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

TODOs

@marandaneto marandaneto changed the base branch from main to feature/unified-api October 21, 2020 08:40
@marandaneto marandaneto changed the title ref/event gpu ref: Event now is SentryEvent and added GPU Oct 21, 2020
@marandaneto marandaneto requested a review from rxlabz October 21, 2020 08:41
@marandaneto marandaneto merged commit b51b0da into feature/unified-api Oct 22, 2020
@marandaneto marandaneto deleted the ref/event-gpu branch October 22, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxlabz rxlabz rxlabz approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @rxlabz