Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: SentryId generates UUID #119

Merged
merged 8 commits into from
Oct 21, 2020
Merged

ref: SentryId generates UUID #119

merged 8 commits into from
Oct 21, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 20, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

ref: SentryId generates UUID

💡 Motivation and Context

we don't need to have a reference of the Uuid generator everywhere, and still, it's testable.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the base branch from main to feature/unified-api October 20, 2020 16:03
@marandaneto marandaneto changed the title ref/sentry id ref: SentryId generates UUID Oct 20, 2020
@marandaneto marandaneto requested a review from rxlabz October 20, 2020 16:04
@marandaneto marandaneto marked this pull request as draft October 20, 2020 16:32
@marandaneto marandaneto marked this pull request as ready for review October 20, 2020 20:10
@marandaneto marandaneto merged commit 19f5592 into feature/unified-api Oct 21, 2020
@marandaneto marandaneto deleted the ref/sentry-id branch October 21, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

@rxlabz rxlabz Awaiting requested review from rxlabz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marandaneto @rxlabz @bruno-garcia