Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Unified API #117

Merged
merged 37 commits into from
Oct 29, 2020
Merged

feature: Unified API #117

merged 37 commits into from
Oct 29, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 20, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

feature: Unified API

💡 Motivation and Context

SDK follows the Sentry convention for SDKs
https://develop.sentry.dev/sdk/unified-api/

💚 How did you test it?

running samples and unit/integration tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

marandaneto and others added 4 commits October 14, 2020 13:46
@marandaneto
Merge branch 'main' into feature/unified-api
163cce7
@marandaneto
Merge branch 'main' into feature/unified-api
b91c954
@rxlabz
feat : static SDK main entry withSentry.init(options),... (#108)
5018978 
* feat : add a static SDK main entry withSentry.init(options), .captureEvent(...), .captureException(...)
* feat: add Scope class
* add a OptionsConfiguration typedef
Co-authored-by: Manoel Aranda Neto <[email protected]>
@rxlabz
Feat : add a Hub class (#113)
d577e35
@marandaneto marandaneto marked this pull request as draft October 20, 2020 11:30
@marandaneto marandaneto requested a review from rxlabz October 20, 2020 11:30
@marandaneto marandaneto changed the title feature/unified api feature: unified api Oct 20, 2020
marandaneto and others added 19 commits October 20, 2020 15:48
@marandaneto
feat: sentry options (#116)
fabf56f
@marandaneto
ref: Hub passes the Scope (#114)
2b36bec
@rxlabz
Refacto : initialize SentryClient with SentryOptions (#118)
af3ecc0
@marandaneto
ref: SentryId generates UUID (#119)
19f5592
@marandaneto
ref: Event now is SentryEvent and added GPU (#121)
b51b0da
@marandaneto
feat: before breadcrumb and scope ref (#122)
3fa0b79
@marandaneto
Ref: Hint is passed across Sentry static class, Hub and Client (#124)
2cc1d78
@marandaneto
Ref: Remove stackFrameFilter in favor of beforeSendCallback (#125)
11b821b
@marandaneto
Ref: Sentry init with null and empty DSN and close method (#126)
ee737a2
@rxlabz
Refacto : add a Transport class (#123)
eab4ccf
@marandaneto
Ref: execute before send callback (#128)
c301ec6 
* ref: execute before send

* changelog

* fix test name
@marandaneto
feat: addBreadcrumb to the Sentry static API (#133)
1794f04
@marandaneto
Feat: add lastEventId to the Sentry static API (#134)
e7db5d1
@marandaneto
Fix: Breadcrumb data should accept serializable types and not only St…
dc962ae 
…ring values (#139)
@marandaneto
Fix: NoOp encode for Web (#138)
b9cd68b
@marandaneto
Fix: execute Integrations on Hub creation (#136)
7b81890
@rxlabz
unified api fixes and add web example (#137)
b1761f4
@rxlabz
Ref/prepare event & scope.applyToEvent (#140)
d249c97
@rxlabz
Ref : rename files accordely to their content (#141)
dc258d9
@bruno-garcia
Copy link
Member

Make sure not to squash this PR 👍

bruno-garcia
bruno-garcia reviewed Oct 27, 2020
View reviewed changes
@marandaneto
Copy link
Contributor Author

a few TODOs:

https://github.com/getsentry/sentry-dart/projects/1#card-48213380
https://github.com/getsentry/sentry-dart/projects/1#card-47082476
https://github.com/getsentry/sentry-dart/projects/1#card-47082234

@marandaneto marandaneto marked this pull request as ready for review October 27, 2020 22:11
@marandaneto marandaneto changed the title feature: unified api feature: Unified API Oct 27, 2020
@marandaneto
Copy link
Contributor Author

Draft of the docs getsentry/sentry-docs#2599

@marandaneto marandaneto mentioned this pull request Oct 28, 2020
Merged
8 tasks
rxlabz
rxlabz approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@rxlabz rxlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit d24cb50 into main Oct 29, 2020
@marandaneto marandaneto deleted the feature/unified-api branch October 29, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia left review comments

@rxlabz rxlabz rxlabz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marandaneto @bruno-garcia @rxlabz