Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sentry options #116

Merged
merged 7 commits into from
Oct 20, 2020
Merged

feat: sentry options #116

merged 7 commits into from
Oct 20, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 20, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

feat: sentry options

💡 Motivation and Context

users should be able to configure options by mutating it on SDK init.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

work on the TODOs

@marandaneto marandaneto changed the base branch from main to feature/unified-api October 20, 2020 11:14
@marandaneto marandaneto requested a review from rxlabz October 20, 2020 11:14
@marandaneto marandaneto changed the title feat/sentry options feat: sentry options Oct 20, 2020
@marandaneto marandaneto requested a review from rxlabz October 20, 2020 12:51
Copy link
Contributor

@rxlabz rxlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit fabf56f into feature/unified-api Oct 20, 2020
@marandaneto marandaneto deleted the feat/sentry_options branch October 20, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants