-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Target cocoapod Sentry/HybridSDK subspec #1113
Conversation
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
559d28f | 302.35 ms | 339.53 ms | 37.18 ms |
eecbbca | 324.37 ms | 352.49 ms | 28.12 ms |
3e9fb0e | 329.14 ms | 359.16 ms | 30.02 ms |
04db237 | 330.16 ms | 428.38 ms | 98.22 ms |
d7758e8 | 300.12 ms | 349.88 ms | 49.76 ms |
af2d175 | 279.08 ms | 312.37 ms | 33.29 ms |
49a149b | 301.96 ms | 344.51 ms | 42.55 ms |
72dfc83 | 298.62 ms | 340.14 ms | 41.52 ms |
1c6eb5b | 350.69 ms | 393.86 ms | 43.17 ms |
9f9f94f | 331.04 ms | 368.92 ms | 37.88 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
559d28f | 5.94 MiB | 6.92 MiB | 1001.70 KiB |
eecbbca | 5.94 MiB | 6.89 MiB | 975.78 KiB |
3e9fb0e | 5.94 MiB | 6.95 MiB | 1.01 MiB |
04db237 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
d7758e8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
af2d175 | 5.94 MiB | 6.92 MiB | 1001.83 KiB |
49a149b | 5.94 MiB | 6.92 MiB | 1001.54 KiB |
72dfc83 | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
1c6eb5b | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
9f9f94f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
Previous results on branch: chore/import-hybridsdk-header
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5ed2676 | 294.98 ms | 345.41 ms | 50.43 ms |
fc1001a | 325.02 ms | 373.56 ms | 48.54 ms |
c2b3e75 | 319.41 ms | 359.22 ms | 39.81 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5ed2676 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
fc1001a | 5.94 MiB | 6.95 MiB | 1.01 MiB |
c2b3e75 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
Codecov ReportBase: 90.21% // Head: 90.21% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 117 117
Lines 3597 3597
=======================================
Hits 3245 3245
Misses 352 352 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@brustolin What version will it be in v7.32.0? |
We can close #1123 if this is green. |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6d317ea | 1277.27 ms | 1287.47 ms | 10.20 ms |
b728df4 | 1287.43 ms | 1293.94 ms | 6.51 ms |
5603ab2 | 1268.47 ms | 1280.73 ms | 12.26 ms |
4efee31 | 1270.33 ms | 1285.75 ms | 15.42 ms |
870f5eb | 1267.78 ms | 1286.86 ms | 19.08 ms |
eb1a7c1 | 1281.25 ms | 1295.40 ms | 14.15 ms |
0ceb89c | 1252.02 ms | 1271.78 ms | 19.75 ms |
6957bfd | 1283.80 ms | 1289.00 ms | 5.20 ms |
56810ff | 1267.59 ms | 1293.48 ms | 25.89 ms |
f922f8f | 1249.53 ms | 1266.51 ms | 16.98 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6d317ea | 8.15 MiB | 9.12 MiB | 986.26 KiB |
b728df4 | 8.15 MiB | 9.15 MiB | 1020.72 KiB |
5603ab2 | 8.15 MiB | 9.12 MiB | 990.57 KiB |
4efee31 | 8.15 MiB | 9.12 MiB | 991.35 KiB |
870f5eb | 8.15 MiB | 9.13 MiB | 1000.08 KiB |
eb1a7c1 | 8.15 MiB | 9.13 MiB | 1000.10 KiB |
0ceb89c | 8.15 MiB | 9.12 MiB | 989.78 KiB |
6957bfd | 8.15 MiB | 9.15 MiB | 1020.71 KiB |
56810ff | 8.15 MiB | 9.12 MiB | 987.35 KiB |
f922f8f | 8.15 MiB | 9.13 MiB | 1003.20 KiB |
Previous results on branch: chore/import-hybridsdk-header
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c2b3e75 | 1274.98 ms | 1294.83 ms | 19.86 ms |
fc1001a | 1278.81 ms | 1299.82 ms | 21.00 ms |
5ed2676 | 1280.21 ms | 1306.69 ms | 26.47 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c2b3e75 | 8.15 MiB | 9.15 MiB | 1019.81 KiB |
fc1001a | 8.15 MiB | 9.15 MiB | 1019.88 KiB |
5ed2676 | 8.16 MiB | 9.15 MiB | 1020.67 KiB |
Co-authored-by: Manoel Aranda Neto <[email protected]>
Add a dependency to Sentry/HybridSDK cocoa subspec, to have access to
PrivateSentrySDKOnly.h
.We need to release the next iOS version before merging this.
close #1124
#skip-changelog