Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature : static SDK main entry withSentry.init(options),... #108

Merged
merged 18 commits into from
Oct 14, 2020
Merged

feature : static SDK main entry withSentry.init(options),... #108

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6b4d9aa
feature : add a static SDK main entry withSentry.init(options), .capt…
rxlabz Oct 13, 2020
f091386
changelog
rxlabz Oct 13, 2020
43109b3
feat: add Scope class
marandaneto Oct 13, 2020
03405a0
add comments
marandaneto Oct 13, 2020
870724a
remove a useless method
rxlabz Oct 13, 2020
898b451
export `sentry_options.dart`
rxlabz Oct 13, 2020
d9652da
add OptionsConfiguration
rxlabz Oct 13, 2020
408fa5a
rename `environmentAttributes` to `environment`
rxlabz Oct 13, 2020
ae4689a
Merge branch 'main' into feat/scope
marandaneto Oct 14, 2020
b971db2
added getters and setters
marandaneto Oct 14, 2020
6459069
changelog
marandaneto Oct 14, 2020
c070153
changelog
marandaneto Oct 14, 2020
0c2aaaf
Merge branch 'feature/unified-api' into feat/scope
marandaneto Oct 14, 2020
cf5cd50
turn OptionsConfiguration to a typedef
rxlabz Oct 14, 2020
83c59d4
rename every `environmentAttributes` to `environment`
rxlabz Oct 14, 2020
02d0918
Merge remote-tracking branch 'origin/feature/unified-api' into featur…
rxlabz Oct 14, 2020
f63ac27
revert `environmentAttributes` renaming
rxlabz Oct 14, 2020
edf665a
Merge remote-tracking branch 'origin/feat/scope' into feature/static-…
rxlabz Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dart/lib/src/client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ abstract class SentryClient {
/// `dart:html` is available, otherwise it will throw an unsupported error.
factory SentryClient({
@required String dsn,
Event environmentAttributes,
Event environment,
bool compressPayload,
Client httpClient,
dynamic clock,
UuidGenerator uuidGenerator,
}) =>
createSentryClient(
dsn: dsn,
environmentAttributes: environmentAttributes,
environmentAttributes: environment,
httpClient: httpClient,
clock: clock,
uuidGenerator: uuidGenerator,
Expand Down
4 changes: 3 additions & 1 deletion dart/lib/src/sentry.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import 'dart:async';

import 'package:meta/meta.dart';

import 'client.dart';
Expand All @@ -16,7 +18,7 @@ class Sentry {
optionsConfiguration.configure(options);
_client = SentryClient(
dsn: options.dsn,
environmentAttributes: options.environmentAttributes,
environment: options.environment,
compressPayload: options.compressPayload,
httpClient: options.httpClient,
clock: options.clock,
Expand Down
4 changes: 2 additions & 2 deletions dart/lib/src/sentry_options.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class SentryOptions {
/// event to event, such as local operating system version, the version of
/// Dart/Flutter SDK, etc. These attributes have lower precedence than those
/// supplied in the even passed to [capture].
Event environmentAttributes;
Event environment;

/// If [compressPayload] is `true` the outgoing HTTP payloads are compressed
/// using gzip. Otherwise, the payloads are sent in plain UTF8-encoded JSON
Expand All @@ -44,7 +44,7 @@ class SentryOptions {

SentryOptions({
this.dsn,
this.environmentAttributes,
this.environment,
this.compressPayload,
this.httpClient,
this.clock,
Expand Down
3 changes: 1 addition & 2 deletions dart/test/sentry_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ void main() {

Exception anException;

final dns =
'https://[email protected]/5428562';
final dns = 'https://[email protected]/1234567';

setUp(() {
Sentry.init(Options(dsn: dns));
Expand Down
8 changes: 4 additions & 4 deletions dart/test/test_utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Future testCaptureException(
clock: fakeClockProvider,
uuidGenerator: () => 'X' * 32,
compressPayload: compressPayload,
environmentAttributes: const Event(
environment: const Event(
serverName: 'test.server.com',
release: '1.2.3',
environment: 'staging',
Expand Down Expand Up @@ -233,7 +233,7 @@ void runTest({Codec<List<int>, List<int>> gzip, bool isWeb = false}) {
clock: fakeClockProvider,
compressPayload: false,
uuidGenerator: () => 'X' * 32,
environmentAttributes: const Event(
environment: const Event(
serverName: 'test.server.com',
release: '1.2.3',
environment: 'staging',
Expand Down Expand Up @@ -290,7 +290,7 @@ void runTest({Codec<List<int>, List<int>> gzip, bool isWeb = false}) {
clock: fakeClockProvider,
uuidGenerator: () => 'X' * 32,
compressPayload: false,
environmentAttributes: const Event(
environment: const Event(
serverName: 'test.server.com',
release: '1.2.3',
environment: 'staging',
Expand Down Expand Up @@ -347,7 +347,7 @@ void runTest({Codec<List<int>, List<int>> gzip, bool isWeb = false}) {
clock: fakeClockProvider,
uuidGenerator: () => 'X' * 32,
compressPayload: false,
environmentAttributes: const Event(
environment: const Event(
serverName: 'test.server.com',
release: '1.2.3',
environment: 'staging',
Expand Down