Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contradicting info in the README about loadStructuredData in sentry_flutter #1381

Closed
vincevargadev opened this issue Apr 5, 2023 · 2 comments · Fixed by #1383
Closed

Contradicting info in the README about loadStructuredData in sentry_flutter #1381

vincevargadev opened this issue Apr 5, 2023 · 2 comments · Fixed by #1383

Comments

@vincevargadev
Copy link

vincevargadev commented Apr 5, 2023

Platform

Flutter

Version

7.4.0

Steps to Reproduce

It's somewhat confusing to me whether loadStructuredData is still experimental and whether using it could lead to bugs.

The README in 7.4.0 says:

Tracing for AssetBundle.loadStructuredData() is currently disabled. It's hidden by the enableStructuredDataTracing flag and considered experimental. Using it could lead to bugs. We recognize the irony.

The Docs says:

The loadStructuredData is an opt-out feature. The following example shows how to disable it:

The code says:

  SentryAssetBundle({
    // ...
    bool enableStructuredDataTracing = true,
  }) /* ... */;

The changelog says (7.0.0)

  • Enable APM features by default (#1217)
    • Enable by default
      • enableStructuredDataTracing

Expected Result

I expect all sources say the same thing. Potentially outdated README?

@ueman
Copy link
Collaborator

ueman commented Apr 5, 2023

That feature is considered stable as mentioned in the changelog, and the docs/readme are just not updated to reflect that.

@marandaneto
Copy link
Contributor

Good catch, #1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants