Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing Breadcrumb.data from Map<String, String> to Map<String, dynamic> #129

Closed
kuhnroyal opened this issue Oct 23, 2020 · 1 comment

Comments

@kuhnroyal
Copy link
Contributor

Sentry accepts the breadcrumb data as complex JSON content.
This is currently not possible to send as the data field is currently final Map<String, String> data;.

Other SDKs also accept object types as values.
When the data fields are JSON objects, data scrubbing would work on the fields. Atm I have to transform objects to Strings and data scrubbing doesn't work.

Btw, the issue templates are still for the sentry_flutter package if anyone can change this.

@bruno-garcia
Copy link
Member

Thanks for raising. We should consider changing it to <String, Object> and serialize the data. We're not using reflection so it might be a best effort there (i.e: Serialize only 1 level and basic types like String, Int etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants