Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min Dart SDK version #115

Closed
bruno-garcia opened this issue Oct 19, 2020 · 7 comments
Closed

Min Dart SDK version #115

bruno-garcia opened this issue Oct 19, 2020 · 7 comments

Comments

@bruno-garcia
Copy link
Member

We're releasing 4.0.0 which is a big major version so it's time to discuss the min Dart SDK version we want to support on the sentry package.

Important notes:

  • Dart just released 2.10
  • Extension methods were introduced on 2.7
  • 2.7 was introduced in December 2019
  • Flutter's new releases often update to the latest Dart SDK version
    • i.e: Version note: As of Flutter 1.21, the Flutter SDK includes the full Dart SDK. This site’s documentation and examples use version 2.10.0 of the Dart SDK.

I'd propose we set the min version to 2.7:

sdk: ^2.0.0

To clarify: What would we leaving behind? Is there a reason folks using AngularDart can't be on Dart 2.7?

@rxlabz
Copy link
Contributor

rxlabz commented Oct 21, 2020

FYI Angular is now using Dart >= 2.8.4 https://github.com/dart-lang/angular/blob/master/angular/pubspec.yaml
I think we can/should upgrade to 2.7 (at least).
And as we started to prepare the NNBD, we'll need to move to the last SDK version if we want to use it.

@marandaneto
Copy link
Contributor

marandaneto commented Oct 21, 2020

we'll need to move to the last SDK version if we want to use it.

this goes heavily against https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king

I'm all in for new features, but if it breaks a good amount of people, I prefer to keep using https://pub.dev/packages/meta at least for a few more months after NNBD being GA, and also checking how NNBD deals with 3rd parties that are not NNBD ready, I guess this will be common for a while

@bruno-garcia
Copy link
Member Author

we'll need to move to the last SDK version if we want to use it.

Yeah, last version is just not an option.

I noticed other packages have a second package name with nullability on the name or something?

Sounds easier for us to just wait out on this, it seems.

@bruno-garcia
Copy link
Member Author

I opened a poll, lets see if we get enough data:

https://twitter.com/brungarc/status/1318947753620348934?s=20

@rxlabz
Copy link
Contributor

rxlabz commented Oct 21, 2020

almost all the Dart team packages (http, meta, path, ...) are now >= 2.10 and are prepared to NNBD https://pub.dev/dart/packages?sort=popularity

@bruno-garcia
Copy link
Member Author

That's a very compelling reason to go for 2.10 🤐

@marandaneto
Copy link
Contributor

https://github.com/getsentry/sentry-dart/releases/tag/4.0.0-alpha.2
Breaking changes section states the minSDK for Dart and Flutter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants