add origin to sqflite span

getsentry · Jun 26, 2023 · 9b84879 · 9b84879
1 parent 5370936
commit 9b84879
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/dart/lib/src/sentry_trace_origins.dart b/dart/lib/src/sentry_trace_origins.dart
@@ -10,6 +10,7 @@ class SentryTraceOrigins {
   static const autoHttpDioSentryTransformer = 'auto.http.dio.sentry_transformer';
   static const autoFile = 'auto.file';
   static const autoFileAssetBundle = 'auto.file.asset_bundle';
+  static const autoFileSqflite = 'auto.file.sqflite';
   static const autoFileSqfliteSentryBatch = 'auto.file.sqflite.sentry_batch';
   static const autoFileSqfliteSentryDatabaseExecutor = 'auto.file.sqflite.sentry_database_executor';
 }
diff --git a/sqflite/lib/src/sentry_sqflite.dart b/sqflite/lib/src/sentry_sqflite.dart
@@ -44,6 +44,8 @@ Future<Database> openDatabaseWithSentry(
       SentryDatabase.dbOp,
       description: 'Open DB: $path',
     );
+    // ignore: invalid_use_of_internal_member
+    span?.origin = SentryTraceOrigins.autoFileSqflite;
 
     try {
       final database =

diff --git a/sqflite/test/sentry_sqflite_test.dart b/sqflite/test/sentry_sqflite_test.dart
@@ -31,6 +31,10 @@ void main() {
       databaseFactory = databaseFactoryFfi;
     });
 
+    tearDown(() {
+      databaseFactory = sqfliteDatabaseFactoryDefault;
+    });
+
     test('returns wrapped data base if performance enabled', () async {
       final db =
           await openDatabaseWithSentry(inMemoryDatabasePath, hub: fixture.hub);
@@ -82,10 +86,24 @@ void main() {
       await db.close();
     });
 
-    tearDown(() {
-      databaseFactory = sqfliteDatabaseFactoryDefault;
+    test('creates db open span', () async {
+      final db =
+      await openDatabaseWithSentry(inMemoryDatabasePath, hub: fixture.hub);
+
+      final span = fixture.tracer.children.last;
+
+      expect(span.context.operation, SentryDatabase.dbOp);
+      expect(span.context.description, 'Open DB: $inMemoryDatabasePath');
+      expect(span.status, SpanStatus.ok());
+      // ignore: invalid_use_of_internal_member
+      expect(span.origin, SentryTraceOrigins.autoFileSqflite);
+
+      await db.close();
     });
+
   });
+
+
 }
 
 class Fixture {