set origin for http tracing client and dio tracing client adapter

getsentry · Jun 20, 2023 · 8d011af · 8d011af
1 parent f6f2559
commit 8d011af
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 0 deletions.
diff --git a/dart/lib/src/http_client/tracing_client.dart b/dart/lib/src/http_client/tracing_client.dart
@@ -2,6 +2,7 @@ import 'package:http/http.dart';
 import '../hub.dart';
 import '../hub_adapter.dart';
 import '../protocol.dart';
+import '../sentry_trace_origins.dart';
 import '../tracing.dart';
 import '../utils/tracing_utils.dart';
 import '../utils/http_sanitizer.dart';
@@ -33,6 +34,7 @@ class TracingClient extends BaseClient {
       'http.client',
       description: description,
     );
+    span?.origin = SentryTraceOrigins.autoHttpHttpTracingClient;
 
     // if the span is NoOp, we don't want to attach headers
     if (span is NoOpSentrySpan) {

diff --git a/dart/lib/src/sentry_trace_origins.dart b/dart/lib/src/sentry_trace_origins.dart
@@ -5,4 +5,6 @@ class SentryTraceOrigins {
   static const manual = 'manual';
 
   static const autoNavigationSentryNavigatorObserver = 'auto.navigation.sentry_navigator_observer';
+  static const autoHttpHttpTracingClient = 'auto.http.http.tracing_client';
+  static const autoHttpDioTracingClientAdapter = 'auto.http.dio.tracing_client_adapter';
 }
diff --git a/dart/test/http_client/tracing_client_test.dart b/dart/test/http_client/tracing_client_test.dart
@@ -44,6 +44,7 @@ void main() {
       expect(span.data['http.fragment'], 'baz');
       expect(span.data['http.response.status_code'], 200);
       expect(span.data['http.response_content_length'], 2);
+      expect(span.origin, SentryTraceOrigins.autoHttpHttpTracingClient);
     });
 
     test('finish span if errored request', () async {

diff --git a/dio/lib/src/tracing_client_adapter.dart b/dio/lib/src/tracing_client_adapter.dart
@@ -38,6 +38,9 @@ class TracingClientAdapter implements HttpClientAdapter {
       description: description,
     );
 
+    // ignore: invalid_use_of_internal_member
+    span?.origin = SentryTraceOrigins.autoHttpDioTracingClientAdapter;
+
     // if the span is NoOp, we don't want to attach headers
     if (span is NoOpSentrySpan) {
       span = null;

diff --git a/dio/test/tracing_client_adapter_test.dart b/dio/test/tracing_client_adapter_test.dart
@@ -49,6 +49,7 @@ void main() {
       expect(span.data['http.fragment'], 'baz');
       expect(span.data['http.response.status_code'], 200);
       expect(span.data['http.response_content_length'], 2);
+      expect(span.origin, SentryTraceOrigins.autoHttpDioTracingClientAdapter);
     });
 
     test('finish span if errored request', () async {