introduce seperate 'auto.file.sqflite.sentry_database' origin

getsentry · Jun 26, 2023 · 77f6137 · 77f6137
1 parent ec81fa0
commit 77f6137
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/dart/lib/src/sentry_trace_origins.dart b/dart/lib/src/sentry_trace_origins.dart
@@ -15,6 +15,8 @@ class SentryTraceOrigins {
   static const autoFileAssetBundle = 'auto.file.asset_bundle';
   static const autoFileSqflite = 'auto.file.sqflite';
   static const autoFileSqfliteSentryBatch = 'auto.file.sqflite.sentry_batch';
+  static const autoFileSqfliteSentryDatabase =
+      'auto.file.sqflite.sentry_database';
   static const autoFileSqfliteSentryDatabaseExecutor =
       'auto.file.sqflite.sentry_database_executor';
   static const autoFileSqfliteSentrySqfliteDatabaseFactory =

diff --git a/sqflite/lib/src/sentry_database.dart b/sqflite/lib/src/sentry_database.dart
@@ -61,7 +61,7 @@ class SentryDatabase extends SentryDatabaseExecutor implements Database {
         description: 'Close DB: ${_database.path}',
       );
       // ignore: invalid_use_of_internal_member
-      span?.origin = SentryTraceOrigins.autoFileSqfliteSentryDatabaseExecutor;
+      span?.origin = SentryTraceOrigins.autoFileSqfliteSentryDatabase;
 
       try {
         await _database.close();
@@ -112,7 +112,7 @@ class SentryDatabase extends SentryDatabaseExecutor implements Database {
         description: 'Transaction DB: ${_database.path}',
       );
       // ignore: invalid_use_of_internal_member
-      span?.origin = SentryTraceOrigins.autoFileSqfliteSentryDatabaseExecutor;
+      span?.origin = SentryTraceOrigins.autoFileSqfliteSentryDatabase;
 
       Future<T> newAction(Transaction txn) async {
         final executor =

diff --git a/sqflite/test/sentry_database_test.dart b/sqflite/test/sentry_database_test.dart
@@ -67,11 +67,10 @@ void main() {
       expect(span.context.operation, 'db');
       expect(span.context.description, 'Close DB: $inMemoryDatabasePath');
       expect(span.status, SpanStatus.ok());
-
       expect(
         span.origin,
         // ignore: invalid_use_of_internal_member
-        SentryTraceOrigins.autoFileSqfliteSentryDatabaseExecutor,
+        SentryTraceOrigins.autoFileSqfliteSentryDatabase,
       );
     });
 
@@ -85,11 +84,10 @@ void main() {
       expect(span.context.operation, 'db.sql.transaction');
       expect(span.context.description, 'Transaction DB: $inMemoryDatabasePath');
       expect(span.status, SpanStatus.ok());
-
       expect(
         span.origin,
         // ignore: invalid_use_of_internal_member
-        SentryTraceOrigins.autoFileSqfliteSentryDatabaseExecutor,
+        SentryTraceOrigins.autoFileSqfliteSentryDatabase,
       );
 
       await db.close();
@@ -164,7 +162,7 @@ void main() {
       expect(
         span.origin,
         // ignore: invalid_use_of_internal_member
-        SentryTraceOrigins.autoFileSqfliteSentryDatabaseExecutor,
+        SentryTraceOrigins.autoFileSqfliteSentryDatabase,
       );
     });
 
@@ -186,7 +184,7 @@ void main() {
       expect(
         span.origin,
         // ignore: invalid_use_of_internal_member
-        SentryTraceOrigins.autoFileSqfliteSentryDatabaseExecutor,
+        SentryTraceOrigins.autoFileSqfliteSentryDatabase,
       );
     });
   });