Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: invert launch arg so feedback widget is injected by default #4901

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Feb 26, 2025

Before we generate a release dogfood build of iOS-Swift as part of releasing the user feedback feature, we need to change showing the feedback widget from opt-in via launch arg, to opt-out, as that was previously the only way to show it, but we can't set launch args in the dogfood build.

#skip-changelog

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.33 ms 1246.78 ms 16.45 ms
Size 22.31 KiB 821.35 KiB 799.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
075a044 1237.26 ms 1255.36 ms 18.10 ms
7fb7afb 1235.00 ms 1256.81 ms 21.81 ms
2b19b82 1212.94 ms 1252.84 ms 39.90 ms
257c2a9 1231.45 ms 1252.12 ms 20.67 ms
6129be5 1215.65 ms 1247.18 ms 31.54 ms
3bf3c92 1236.94 ms 1253.00 ms 16.06 ms
5d6ce0e 1237.10 ms 1257.46 ms 20.36 ms
319f0f5 1229.68 ms 1247.67 ms 17.99 ms
7cd187e 1239.39 ms 1258.02 ms 18.63 ms
48e8c2e 1231.00 ms 1244.52 ms 13.52 ms

App size

Revision Plain With Sentry Diff
075a044 20.76 KiB 420.41 KiB 399.65 KiB
7fb7afb 20.76 KiB 419.69 KiB 398.94 KiB
2b19b82 21.58 KiB 542.18 KiB 520.59 KiB
257c2a9 20.76 KiB 401.36 KiB 380.60 KiB
6129be5 21.58 KiB 418.00 KiB 396.42 KiB
3bf3c92 21.58 KiB 706.06 KiB 684.48 KiB
5d6ce0e 22.85 KiB 405.38 KiB 382.53 KiB
319f0f5 22.30 KiB 749.70 KiB 727.40 KiB
7cd187e 20.76 KiB 401.65 KiB 380.89 KiB
48e8c2e 21.58 KiB 418.44 KiB 396.86 KiB

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armcknight armcknight merged commit ebf1c9c into main Feb 26, 2025
57 checks passed
@armcknight armcknight deleted the armcknight/feat(feedback)/enable-widget-in-sample branch February 26, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants