-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: High risk file changes as PR comment #3554
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚨 Detected changes in high risk files 🚨Take an extra careful look at the following files:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4654f66 | 1247.16 ms | 1263.96 ms | 16.80 ms |
4d5eb78 | 1197.86 ms | 1215.73 ms | 17.88 ms |
23e2db5 | 1240.96 ms | 1253.86 ms | 12.90 ms |
efb2222 | 1245.10 ms | 1249.10 ms | 4.00 ms |
e84bc3f | 1257.08 ms | 1267.41 ms | 10.33 ms |
6001822 | 1233.31 ms | 1251.64 ms | 18.33 ms |
ac614f1 | 1252.86 ms | 1260.30 ms | 7.44 ms |
1bbcb9c | 1192.51 ms | 1231.96 ms | 39.45 ms |
7f14650 | 1249.73 ms | 1269.88 ms | 20.14 ms |
2154ae1 | 1216.06 ms | 1244.78 ms | 28.72 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4654f66 | 20.76 KiB | 432.17 KiB | 411.41 KiB |
4d5eb78 | 21.58 KiB | 418.74 KiB | 397.16 KiB |
23e2db5 | 20.76 KiB | 434.97 KiB | 414.21 KiB |
efb2222 | 20.76 KiB | 424.45 KiB | 403.69 KiB |
e84bc3f | 20.76 KiB | 434.72 KiB | 413.96 KiB |
6001822 | 22.85 KiB | 410.99 KiB | 388.14 KiB |
ac614f1 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
1bbcb9c | 20.76 KiB | 426.10 KiB | 405.34 KiB |
7f14650 | 22.84 KiB | 402.63 KiB | 379.79 KiB |
2154ae1 | 20.76 KiB | 427.83 KiB | 407.06 KiB |
armcknight
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Remove the no changes in high-risk file script and hashes, and replace it by adding a GH PR comment, see example below #3554 (comment).
#skip-changelog
💡 Motivation and Context
Updating the hashes manually is annoying for development. Instead, we should point such changes out in PRs.
💚 How did you test it?
This PR with GH actions. See the comment belowhttps://github.com//pull/3554#issuecomment-1885101130.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps