-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reads UI Windows in the main thread while fetching view hierarchy #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3f1be0f | 1208.12 ms | 1225.72 ms | 17.60 ms |
c6504da | 1232.06 ms | 1243.28 ms | 11.22 ms |
cb2eefe | 1222.04 ms | 1243.04 ms | 21.00 ms |
369222e | 1232.14 ms | 1258.90 ms | 26.76 ms |
621ba9b | 1190.66 ms | 1230.84 ms | 40.18 ms |
56ec5d0 | 1236.65 ms | 1261.90 ms | 25.25 ms |
3a31fc9 | 1237.35 ms | 1249.02 ms | 11.67 ms |
feba2be | 1246.67 ms | 1254.64 ms | 7.97 ms |
56ec5d0 | 1194.39 ms | 1236.94 ms | 42.55 ms |
4c00f8c | 1231.62 ms | 1237.76 ms | 6.14 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3f1be0f | 20.76 KiB | 414.44 KiB | 393.69 KiB |
c6504da | 20.76 KiB | 414.44 KiB | 393.69 KiB |
cb2eefe | 20.76 KiB | 419.62 KiB | 398.86 KiB |
369222e | 20.76 KiB | 419.67 KiB | 398.91 KiB |
621ba9b | 20.76 KiB | 414.45 KiB | 393.69 KiB |
56ec5d0 | 20.76 KiB | 414.44 KiB | 393.69 KiB |
3a31fc9 | 20.76 KiB | 414.45 KiB | 393.69 KiB |
feba2be | 20.76 KiB | 414.45 KiB | 393.69 KiB |
56ec5d0 | 20.76 KiB | 414.44 KiB | 393.68 KiB |
4c00f8c | 20.76 KiB | 419.62 KiB | 398.86 KiB |
philipphofmann
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @brustolin 👏
Co-authored-by: Philipp Hofmann <[email protected]>
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Reads UI Windows in the main thread while fetching view hierarchy ([#2629](https://github.com/getsentry/sentry-cocoa/pull/2629)) If none of the above apply, you can opt out of this check by adding |
philipphofmann
pushed a commit
that referenced
this pull request
Jan 23, 2023
#2629) Reads UI Windows in the main thread while fetching view hierarchy Co-authored-by: Philipp Hofmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Reads UI Windows in the main thread while fetching view hierarchy
💡 Motivation and Context
Closes #2586
💚 How did you test it?
Unit test
📝 Checklist
🔮 Next steps