test: Fix SentryStacktraceBuilderTests #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testAsyncStacktraces should be testing if stack traces of different threads are stitched together, which it didn't do, because we were only building the stack trace on the main thread. This is fixed now by building the stack trace across different threads. Furthermore, the tests now use its own queue to avoid side effects when testing.
Codecov Report
@@ Coverage Diff @@
## master #1372 +/- ##
==========================================
+ Coverage 95.45% 95.54% +0.09%
==========================================
Files 153 153
Lines 5500 5500
==========================================
+ Hits 5250 5255 +5
+ Misses 250 245 -5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
testAsyncStacktraces should be testing if stack traces of different threads
are stitched together, which it didn't do, because we were only building
the stack trace on the main thread. This is fixed now by building the
stack trace across different threads. Furthermore, the tests now use
their own queue to avoid side effects when testing.
#skip-changelog
💡 Motivation and Context
Fixes failing tests in #1371