fix: Crash for Call Should be on Main Thread #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The swizzling of subclasses of UIViewController stored references to classes on a background thread, which led to calling the initialize method. Some UIViewControllers implementing assume that they are on the main thread when executing initialize. Calling initialize from a background thread can lead to crashes. This is fixed now by avoiding the call to initialize on a background thread and swizzling on the main thread. Fixes GH-1366
testAsyncStacktraces should be testing if stack traces of different threads are stitched together, which it didn't do, because we were only building the stack trace on the main thread. This is fixed now by building the stack trace across different threads. Furthermore, the tests now use its own queue to avoid side effects when testing.
testAsyncStacktraces should be testing if stack traces of different threads are stitched together, which it didn't do, because we were only building the stack trace on the main thread. This is fixed now by building the stack trace across different threads. Furthermore, the tests now use its own queue to avoid side effects when testing.
Codecov Report
@@ Coverage Diff @@
## master #1371 +/- ##
==========================================
+ Coverage 95.45% 95.60% +0.15%
==========================================
Files 153 152 -1
Lines 5500 5509 +9
==========================================
+ Hits 5250 5267 +17
+ Misses 250 242 -8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
The swizzling of subclasses of UIViewController stored
references to classes on a background thread, which led
to calling the initialize method. Some UIViewControllers
implementing assume that they are on the main thread
when executing initialize. Calling initialize from a
background thread can lead to crashes. This is fixed now
by avoiding the call to initialize on a background thread and
swizzling on the main thread.
💡 Motivation and Context
Fixes GH-1366
💚 How did you test it?
Unit tests, UI tests, on a real device and with the sample project pointed out in GH-1366.
📝 Checklist
🔮 Next steps