Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Add SentryMechanismMeta #1038

Merged
merged 5 commits into from
Mar 31, 2021
Merged

Conversation

philipphofmann
Copy link
Member

📜 Description

Replace the dictionary for the mechanism meta for the exception with a
class. Furthermore, move the SentryNSError to SentryMechanismMeta.

💡 Motivation and Context

We want to align the SDK with the exception interface.

💚 How did you test it?

Unit tests and simulator

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the CHANGELOG if needed
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Replace the dictionary for the mechanism meta for the exception with a
class. Furthermore, move the SentryNSError to SentryMechanismMeta.
@philipphofmann philipphofmann requested a review from a team March 31, 2021 09:04
@philipphofmann philipphofmann self-assigned this Mar 31, 2021
@philipphofmann philipphofmann added this to the 7.0.0 milestone Mar 31, 2021
@codecov-io
Copy link

codecov-io commented Mar 31, 2021

Codecov Report

Merging #1038 (7c0f660) into master (f0eb381) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
+ Coverage   94.86%   94.88%   +0.01%     
==========================================
  Files          92       93       +1     
  Lines        4074     4083       +9     
==========================================
+ Hits         3865     3874       +9     
  Misses        209      209              
Impacted Files Coverage Δ
Sources/Sentry/SentryClient.m 94.46% <100.00%> (+0.04%) ⬆️
Sources/Sentry/SentryCrashReportConverter.m 95.03% <100.00%> (ø)
Sources/Sentry/SentryMechanism.m 100.00% <100.00%> (ø)
Sources/Sentry/SentryMechanismMeta.m 100.00% <100.00%> (ø)
Sources/Sentry/SentryCrashIntegration.m 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0eb381...7c0f660. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit ce9d8e3 into master Mar 31, 2021
@philipphofmann philipphofmann deleted the ref/sentry-mechanism-meta branch March 31, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants