sessions sent without an environment when environment option is not set

[kerenkhatiwada]

Description

If the environment is not set for the SDK errors will default to production. However, sessions are sent without an environment.

Expected outcome - sessions would be sent with an environment
Actual outcome: sessions are sent without an environment set

Steps To Reproduce

1. set the environment and release options
2. Send an error event and session
3. Observe that session and error event with the correct environment
4. repeat without setting the environment option
5. Observe the error event with an environment of production
6. Observe the session with no environment

[philipphofmann]

We set the default environment for events here

sentry-cocoa/Sources/Sentry/SentryClient.m

Lines 572 to 575 in 48c7211

	if (nil == event.environment) {
	// We default to environment 'production' if nothing was set
	event.environment = kSentryDefaultEnvironment;
	}

but not when starting the session

sentry-cocoa/Sources/Sentry/SentryHub.m

Lines 96 to 99 in 48c7211

	NSString *environment = options.environment;
	if (nil != environment) {
	_session.environment = environment;
	}

Thanks for reporting this, @kerenkhatiwada.