Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky testSerializeWithUnderlyingNSException #2388

Open
philipphofmann opened this issue Nov 15, 2022 · 4 comments · Fixed by #2387
Open

Fix flaky testSerializeWithUnderlyingNSException #2388

philipphofmann opened this issue Nov 15, 2022 · 4 comments · Fixed by #2387

Comments

@philipphofmann
Copy link
Member

GitHub action Run Link

https://github.com/getsentry/sentry-cocoa/actions/runs/3465967126/jobs/5789326262

Disabling PR

#2387

Description

Also failing https://github.com/getsentry/sentry-cocoa/actions/runs/3468074702/jobs/5793551381

@philipphofmann
Copy link
Member Author

@armcknight, could you please look at this test as you wrote it?

@armcknight
Copy link
Member

I just noticed this because I went to write another test case for a new function in SentryError. The test run crashed while this test case was running, but I really don't see how this test case could crash. Running it locally doesn't crash, I'm guessing this is the same statefulness issue that has been plaguing the test suite. I'm going to reenable it and let's see what happens.

@armcknight
Copy link
Member

I think this got automatically closed due to the way it was included in the PR description.

@armcknight armcknight reopened this Jan 12, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants