Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.4.5 Crash on launch #1395

Closed
charlesbensonsonos opened this issue Oct 15, 2021 · 3 comments · Fixed by #1396
Closed

7.4.5 Crash on launch #1395

charlesbensonsonos opened this issue Oct 15, 2021 · 3 comments · Fixed by #1396
Assignees
@philipphofmann
Labels
Component: Performance Type: Bug

Comments

@charlesbensonsonos
Copy link

charlesbensonsonos commented Oct 15, 2021 •
edited
Loading

Environment

How do you use Sentry?
Sentry SaaS (sentry.io)

Which SDK and version?
Sentry-Cocoa 7.4.5 - IOS 14.5 - iPod touch

Steps to Reproduce

  1. Updated app to 7.4.5 release
  2. Launched app in IDE/Simulator
  3. Observed crash in following method

SentryUiViewControllerSwizziling.m

  • (void)swizzleSubclassesOf:(Class)parentClass
    dispatchQueue:(SentryDispatchQueueWrapper *)dispatchQueue
    swizzleBlock:(void (^)(Class))block

Expected Result

No crash

Actual Result

Crash

For now I have reverted to 7.1.4.

image

image

image
@charlesbensonsonos
Copy link
Author

charlesbensonsonos commented Oct 15, 2021 •
edited
Loading

OneSignal/OneSignal-iOS-SDK#278
Very similar report of the issue here
with fix
OneSignal/OneSignal-iOS-SDK@94cfd7c#diff-a6b243bac2d1163598cb4a56e72e2e245b4236a2bbde17e22d9c6d3fc71cb24a

@philipphofmann
Copy link
Member

Thanks, @charlesbensonsonos for the issue and hint on how to fix that.

@philipphofmann philipphofmann self-assigned this Oct 15, 2021
philipphofmann added a commit that referenced this issue Oct 15, 2021
@philipphofmann
fix: Crash when Getting Subclasses
761707d 
Calling class_getSuperclass sometimes leads to EXC_I386_GPFLT. OneSignal
had the same issue OneSignal/OneSignal-iOS-SDK#278
and it was fixed with OneSignal/OneSignal-iOS-SDK#301.
This PR applies the changes they did to our code to fix the problem.

Fixes GH-1395
@philipphofmann philipphofmann mentioned this issue Oct 15, 2021
Merged
5 tasks
@philipphofmann
Copy link
Member

Hey @charlesbensonsonos, I made a fix with #1396. Could you be so kind and validate with your project that the crash is gone pleased?

philipphofmann added a commit that referenced this issue Oct 18, 2021
@philipphofmann
fix: Crash when Getting Subclasses (#1396)
2931d32 
Calling class_getSuperclass sometimes leads to EXC_I386_GPFLT. OneSignal
had the same issue OneSignal/OneSignal-iOS-SDK#278
and it was fixed with OneSignal/OneSignal-iOS-SDK#301.
This PR applies the changes they did to our code to fix the problem.

Fixes GH-1395
@philipphofmann philipphofmann mentioned this issue Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

Labels
Component: Performance Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Crash when Getting Subclasses getsentry/sentry-cocoa
2 participants
@philipphofmann @charlesbensonsonos