Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make data in data SentrySpanProtocol nonnull #1257

Closed
philipphofmann opened this issue Jul 28, 2021 · 1 comment · Fixed by #2409
Closed

Make data in data SentrySpanProtocol nonnull #1257

philipphofmann opened this issue Jul 28, 2021 · 1 comment · Fixed by #2409
Assignees
@brustolin
Labels
Component: Performance Platform: Cocoa
Milestone
8.0.0

Comments

@philipphofmann
Copy link
Member

The SentrySpanProtocol.data is nullable. So is SentrySpanProtocol.setDataValue:(nullable id)value. We can remove those nullable modifiers.
@philipphofmann philipphofmann added this to the 8.0.0 milestone Jul 28, 2021
@philipphofmann philipphofmann mentioned this issue Jul 28, 2021
Merged
5 tasks
@philipphofmann philipphofmann modified the milestones: 8.0.0, 9.0.0 Nov 16, 2022
@brustolin brustolin mentioned this issue Nov 18, 2022
Merged
5 tasks
@brustolin brustolin linked a pull request Nov 21, 2022 that will close this issue
ref: Make SpanProtocol.data non nullable #2409
Merged
5 tasks
@philipphofmann
Copy link
Member Author

Closed with #2409.

Repository owner moved this from Backlog to Done in Mobile & Cross Platform SDK Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brustolin brustolin

Labels
Component: Performance Platform: Cocoa
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

ref: Make SpanProtocol.data non nullable getsentry/sentry-cocoa
3 participants
@philipphofmann @marandaneto @brustolin