From 3e7aa41e5f1f370d6252b3ffec0ddf359fb684d3 Mon Sep 17 00:00:00 2001 From: Philipp Hofmann Date: Mon, 17 Apr 2023 13:04:17 +0200 Subject: [PATCH] test: Remove noisy logs for TestLogTests (#2909) Don't call super when running testLoggingFromMulitpleThreads to avoid spamming the test logs. --- Tests/SentryTests/TestLogOutput.swift | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Tests/SentryTests/TestLogOutput.swift b/Tests/SentryTests/TestLogOutput.swift index 4e61843805..c5cbc2b8d1 100644 --- a/Tests/SentryTests/TestLogOutput.swift +++ b/Tests/SentryTests/TestLogOutput.swift @@ -6,6 +6,8 @@ class TestLogOutput: SentryLogOutput { private var _loggedMessages: [String] = [] + var callSuperWhenLogging = true + var loggedMessages: [String] { get { queue.sync { @@ -15,7 +17,9 @@ class TestLogOutput: SentryLogOutput { } override func log(_ message: String) { - super.log(message) + if callSuperWhenLogging { + super.log(message) + } queue.async(flags: .barrier) { self._loggedMessages.append(message) } @@ -26,6 +30,7 @@ class TestLogOutPutTests: XCTestCase { func testLoggingFromMulitpleThreads() { let sut = TestLogOutput() + sut.callSuperWhenLogging = false testConcurrentModifications(writeWork: { i in sut.log("Some message \(i)") }, readWork: {