-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kotlin K2 compiler plugin #716
Conversation
|
there's a better maintained fork of kotlin-comple-testing, maybe we should try that one? https://github.com/ZacSweers/kotlin-compile-testing |
Avoid creating potentially unused variables, wrap modifiers in-place instead
Yeah I tried, but unfortunately that fork suffers from the same limitation:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good stuff! I assume it's still backward-compatible with older kotlin compiler versions, right?
looks like the test is failing because we're still running against an older kotlin version. Should we introduce another dimension to the matrix for kotlin versions? |
fqName is discouraged in 2.0.0, and packageFqName didn't exist before 2.0.0
Yeah I tried to do that, but upgrading to Kotlin 2.0 breaks in several areas:
Hate to say it, but I'll create a follow up ticket for this. In the meantime I tested this change with different Kotlin versions locally. |
📜 Description
As of now:
tests are broken, seems to be some configuration/version issue with the compiletesting librarywhen plugin is applied, it no-ops with the following error. This seems to stem from some compiler side API changes, it's probably best to peek into the JPC plugin source and align with their way of doing it.💡 Motivation and Context
Support K2, fixes #698
💚 How did you test it?
📝 Checklist
🔮 Next steps