feat(replays): add replay_id to DSC #1971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
todo: add replay_id here? https://develop.sentry.dev/sdk/performance/dynamic-sampling-context/#baggage-header |
|
moving to draft, my assumptions about how the fields from DSC are used were not correct -- still need to add replay_id to the event explicitly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: add replay_id to the event from DSC.
Related: getsentry/rfcs#60 getsentry/team-webplatform-meta#41
getsentry/sentry#45529
Closes: #1958
(note that ticket now doesn't make sense as i started this -- we don't need to add a whole new context for this, the replay_id can simply exist on the trace context)