Change PagerDuty's default summary text

[arikfr]

Currently PagerDuty's Alert destination default summary text uses the query id and name. We should change it to use the alert name as it's usually better explains what the alert is.

While #4153 implements ability to customize the summary text, it's good to have a saner default regardless.

(If #4153 is not merged before implementing, should be implemented based on its branch)

[frextrite]

Hi @arikfr
I believe

redash/redash/destinations/pagerduty.py

Line 15 in 74beed8

DESCRIPTION_STR = u'Alert - Redash Query #{query_id}: {query_name}'

this needs to be changed. However, I could not find any accessors of notify() function (maybe a problem with my IDE), so I was unable to find the alert object properties. Can I assume I can get the alert name by alert.name?

And also, I would have to change

redash/redash/destinations/pagerduty.py

Line 49 in 74beed8

default_desc = self.DESCRIPTION_STR.format(query_id=query.id, query_name=query.name)

to something like

self.DESCRIPTION_STR.format(alert_name=alert.name)

So can I assume, alert.name will always be non-null or do I need to involve checks?
Thanks!

[frextrite]

So, I dug more and found a few examples of alert.name in redash/destination/