Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Presto username and password #2925

Closed
arikfr opened this issue Oct 10, 2018 · 2 comments · Fixed by #3619
Closed

Support for Presto username and password #2925

arikfr opened this issue Oct 10, 2018 · 2 comments · Fixed by #3619
Labels

Comments

@arikfr
Copy link
Member

arikfr commented Oct 10, 2018

Currently the Presto query runner supports username only. We should support password as well.

This probably requires upgrading the PyHive library.

@Ralnoc
Copy link
Contributor

Ralnoc commented Apr 22, 2019

I have opened PR #3723 that resolves this issue as well as improved support for usernames when not configured through the data source. (For example if you are using SAML auth and want it to honor the original user) And changes the source from pyhive to redash to remove confusion.

  • Username: It uses the configured field for username over all else, then uses the email address to extract the username based on the left side of the @ symbol in the email address and finally, if all of that is missing, defaults to redash.
  • Password: is pulled from a new password field in the configuration page for Presto
  • Source Identifier: It changes the source identifier for pyhive so that instead of reporting itself as pyhive to Presto, it declares itself as redash.

@arikfr
Copy link
Member Author

arikfr commented Apr 3, 2023

This is not related to the issue, but I assume that the issue author or followers might have SAML enabled for their deployment and should be aware of the following Security Advisory: #5961. This affects all Redash versions and should be patched immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants