Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.6 - plugins compatibility #3485

Closed
21 tasks done
distantnative opened this issue Jul 5, 2021 · 45 comments
Closed
21 tasks done

3.6 - plugins compatibility #3485

distantnative opened this issue Jul 5, 2021 · 45 comments
Labels
needs: information ❓ Requires more information to proceed

Comments

@distantnative
Copy link
Member

distantnative commented Jul 5, 2021

Let's collect a list of plugins we know 3.6 will break (and where we could send PRs or give tips how to update):

Done

Please feel free to edit this post, so we have the full list always on top.

@MaluNoPeleke
Copy link

Komments and Commentions need to be added as well.

@lukasbestle
Copy link
Member

Thanks, I added them to the list above.

@mynameisfreedom
Copy link

Image Clip also.

@afbora
Copy link
Member

afbora commented Sep 22, 2021

@mynameisfreedom Thanks, added to list.

@MaluNoPeleke
Copy link

@afbora
Copy link
Member

afbora commented Sep 22, 2021

@MaluNoPeleke Added to list.

@afbora afbora changed the title [3.6.0] Plugins we broke [3.6.0] Plugins compatibility Sep 23, 2021
@afbora afbora pinned this issue Sep 23, 2021
@MaluNoPeleke
Copy link

These two as well:

rasteiner/k3-pagesdisplay-section#9
texnixe/k3-filesdisplay-section#3

These have been fixed and Commentions and Komments have already updated branches for 3.6 (but not released yet officially).

@afbora
Copy link
Member

afbora commented Sep 27, 2021

I've updated the list.

@bnomei
Copy link

bnomei commented Sep 28, 2021

my mailjet plugin as some views as well but can be considered low priority (if any):
https://github.com/bnomei/kirby3-mailjet/tree/master/src/components

@afbora
Copy link
Member

afbora commented Sep 28, 2021

Added to list.

@mauricerenck
Copy link

I am still working on this: https://github.com/mauricerenck/kirby-podcaster

  • The base functionality is working (feed and panel setups).
  • The stats view currently doesn't show data

@PaulMorel
Copy link
Contributor

PaulMorel commented Sep 30, 2021

As someone who has just released a custom panel view plugin, is it going to break in 3.6? I'm assuming this is related to the new Fiber system?

Edit: Maybe I should just go test it myself 😅

@afbora
Copy link
Member

afbora commented Sep 30, 2021

@PaulMorel
Copy link
Contributor

@afbora Is it feasible to have my plugin compatible with both 3.6 and older versions? Or is this a headache waiting to happen?

@afbora
Copy link
Member

afbora commented Sep 30, 2021

@PaulMorel You can use releasement. For example: v0 is <=3.5, v1 is >=3.6

@lukasbestle
Copy link
Member

@PaulMorel I have just worked on an update for my Versions plugin, which also uses a view.

You can actually both register the view in the frontend for older versions and register an area in the backend for 3.6+. 3.6 will ignore the view defined in the frontend and 3.5 and previous versions will ignore the area. Unless your code runs into other breaking changes, you can make an update to your plugin that supports both scenarios.

@mullema
Copy link
Contributor

mullema commented Oct 6, 2021

image-clip (develop branch) works now with beta2

@afbora
Copy link
Member

afbora commented Oct 6, 2021

@mullema Great! I've updated the list.

@bastianallgeier bastianallgeier removed this from the 3.6.0-beta.3 milestone Oct 8, 2021
@bastianallgeier bastianallgeier added this to the 3.6.0 milestone Oct 15, 2021
@steirico
Copy link
Contributor

Hi

there is work in progress for the Custom Add Fields Plugin at https://github.com/steirico/kirby-plugin-custom-add-fields/tree/feature/kirby-3.6

@MaluNoPeleke
Copy link

MaluNoPeleke commented Oct 18, 2021

Here is another one WIP that could need some support: https://github.com/flokosiol/kirby-translations/tree/kirby3

@PaulMorel
Copy link
Contributor

@PaulMorel I have just worked on an update for my Versions plugin, which also uses a view.

You can actually both register the view in the frontend for older versions and register an area in the backend for 3.6+. 3.6 will ignore the view defined in the frontend and 3.5 and previous versions will ignore the area. Unless your code runs into other breaking changes, you can make an update to your plugin that supports both scenarios.

Thanks @lukasbestle, That's exactly what I ended up doing. Registering the area for 3.6+ worked fine and I had very little changes to do for it to still work in 3.5.

@MaluNoPeleke
Copy link

Can you pease add this plugin to the list?

bvdputte/kirby-autopublish#8

@afbora
Copy link
Member

afbora commented Oct 22, 2021

@MaluNoPeleke I've added to the list.

@sebastiangreger
Copy link
Contributor

Markdown Field: fabianmichael/kirby-markdown-field#116 (issue refers to the next branch in active development; haven't tested the current stable version with 3.6, yet)

@sebastiangreger
Copy link
Contributor

Just for completeness, updating the info in the original post on top: Commentions is now 3.6-compatible in newly released versions on both the stable branch (v1.0.5) and the WIP v2.0 branch (v2.0-beta.4).

@mauricerenck
Copy link

Komments latest release (and main branch) is now 3.6 compatible and 3.5 "backward" compatible.

@mauricerenck
Copy link

Kirby Podcaster now works with 3.6

@MaluNoPeleke
Copy link

Can you pease add this plugin to the list?

bvdputte/kirby-autopublish#8

Can be removed as I cannot reproduce anymore after latest plugin update

@thathoff
Copy link
Contributor

thathoff commented Nov 2, 2021

Trying to migrate my OAuth Plugin to 3.6. I hooked into the Vue Router to prevent a redirect to the install view so you can still login with a valid OAuth user even when there is no user created yet.

// always route back to panel home when trying to access installation view
if (panel?.app?.$route?.path === "/installation") {
  panel.app.$go("/");
}

// prevent routing to the installation view (e.g. like the login view does)
panel?.app?.$router?.beforeEach((to, _, next) => {
  if (to.path !== "/installation") next();
});

https://github.com/thathoff/kirby-oauth/blob/kirby-3.6/src/index.js#L12

Any hints on how to accomplish this with Kirby 3.6?

@MaluNoPeleke
Copy link

Komments latest release (and main branch) is now 3.6 compatible and 3.5 "backward" compatible.

I always get a error 500 after installing it on Kirby 3.6 RC.3 without any additional information (debugging turned on).

@mauricerenck
Copy link

Komments latest release (and main branch) is now 3.6 compatible and 3.5 "backward" compatible.

I always get a error 500 after installing it on Kirby 3.6 RC.3 without any additional information (debugging turned on).

Would you be so nice and create an issue in the komments github repo? This is more in my focus, I will have a look at it. Maybe with some additional info about your setup. That would be nice.

@MaluNoPeleke
Copy link

Done: mauricerenck/komments#24

@distantnative distantnative changed the title Plugins compatibility 3.6 - plugins compatibility Nov 15, 2021
@distantnative distantnative added needs: information ❓ Requires more information to proceed and removed type: regression ⚡️ labels Nov 15, 2021
@distantnative distantnative removed this from the 3.6.0 milestone Nov 15, 2021
@bastianallgeier bastianallgeier unpinned this issue Nov 16, 2021
@distantnative distantnative pinned this issue Nov 16, 2021
@sylvainjule
Copy link
Contributor

https://github.com/sylvainjule/kirby-pagetable I've merged the 3.6 support into the latest release

I'm looking into the bouncer plugin next week!

@afbora afbora removed the needs: information ❓ Requires more information to proceed label Dec 16, 2021
@distantnative distantnative added the needs: information ❓ Requires more information to proceed label Dec 20, 2021
@MaluNoPeleke
Copy link

Can you add this plugin and maybe offer support to make it compatible with Kirby 3.6 again?

@texnixe
Copy link
Member

texnixe commented Dec 21, 2021

@MaluNoPeleke This plugin has nothing to do with the changes introduced in 3.6, it wasn't compatible with 3.5 either. Let's not mix things up.

@MaluNoPeleke
Copy link

Oh, sorry, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: information ❓ Requires more information to proceed
Development

No branches or pull requests