Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rounding to minutes messes up plural/singular #5

Closed
ohnonot opened this issue Dec 13, 2016 · 2 comments
Closed

Rounding to minutes messes up plural/singular #5

ohnonot opened this issue Dec 13, 2016 · 2 comments

Comments

@ohnonot
Copy link

ohnonot commented Dec 13, 2016

I am happy to estimate reading time in minutes (without seconds), but the plugin rounds e.g.
"0 minutes 40 seconds" to "1 minutes"
"1 minute 45 seconds" to "2 minute"
and so on.

PS:
I have seen issue nr 3.
@jimblue
Copy link

jimblue commented Jun 9, 2017 •
edited
Loading

Same problem here.
1 minutes is plural should be singular.

@jimblue
Copy link

jimblue commented Jun 9, 2017 •
edited
Loading

Thanks @flaviocopes for the update... fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ohnonot @jimblue