Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Button in Editor Shouldn't Start the http:// #2127

Closed
McLaynV opened this issue Apr 20, 2021 · 4 comments
Closed

Image Button in Editor Shouldn't Start the http:// #2127

McLaynV opened this issue Apr 20, 2021 · 4 comments
Assignees

Comments

@McLaynV
Copy link

McLaynV commented Apr 20, 2021

I suggest the same change as #813 for image

replacer({ name: 'image', replace: '![$1](http://$cur)', codemirror, button });

Another good reason is that HTTPS is getting more common than HTTP.

@mahagr
Copy link
Member

mahagr commented Apr 21, 2021

@w00fz There's no such thing as image: URI, which is why there's no need to handle it as a special case.

@w00fz w00fz closed this as completed in 084002b May 3, 2021
@w00fz
Copy link
Member

w00fz commented May 3, 2021

@mahagr not sure what you mean by image:, this is not a special case.

I think @McLaynV suggestion is to just remove the automatic rendered prefix of http:// when adding an image. I fully agree with this since it was poorly assuming your image URL was going to be remote AND not using SSL.

This is fixed now.

@McLaynV
Copy link
Author

McLaynV commented May 3, 2021

@w00fz
Copy link
Member

w00fz commented May 3, 2021

@McLaynV i believe that file is a leftover from before my cleanup in Nov 2020. I removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants