Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete-button UX #1769

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Delete-button UX #1769

merged 1 commit into from
Oct 23, 2019

Conversation

OleVik
Copy link
Contributor

@OleVik OleVik commented Oct 21, 2019

Fixes #1768.

@paulhibbitts
Copy link
Contributor

paulhibbitts commented Oct 21, 2019 •
edited
Loading

Thanks very much @OleVik for putting together this PR.

Please note that the button label for the modal delete dialog "Continue" button with a checkmark is proposed to be changed to "Delete" with a trash can icon (trash-o), as shown below.

2019-10-21_11-29-52

@OleVik
Copy link
Contributor Author

OleVik commented Oct 21, 2019

The PR does not change the content of the text, only the classes - reassigning danger.

@mahagr mahagr requested a review from rhukster October 22, 2019 08:23
@rhukster rhukster merged commit 44cdd29 into getgrav:1.10 Oct 23, 2019
@paulhibbitts
Copy link
Contributor

Thanks very much @rhukster and @OleVik.

@OleVik OleVik deleted the patch-2 branch November 11, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhukster rhukster Awaiting requested review from rhukster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleVik @paulhibbitts @rhukster