Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling dependency on inventory v0.1 #188

Closed
phil-opp opened this issue Sep 13, 2023 · 2 comments · Fixed by #210
Closed

Allow disabling dependency on inventory v0.1 #188

phil-opp opened this issue Sep 13, 2023 · 2 comments · Fixed by #210
Assignees
Labels
K-feature Kind: proposed new code to implement new behaviour

Comments

@phil-opp
Copy link
Contributor

There are some open security advisories for inventory < v0.2.0: https://rustsec.org/packages/inventory.html . They are not serious, but it would still be nice to provide a way to remove the inventory v0.1 version from the dependency graph.

Since #132, there is an optional inventory-0-3-1 feature, but the header feature still enables the inventory v0.1 dependency unconditionally.

(I tried working around that by enabling the safer_ffi-proc_macros/headers feature manually instead of the top-level headers feature. Unfortunately, this doesn't work since there are multiple #[cfg(feature = "headers")] instances in the code, which are required as well.)

@dignifiedquire
Copy link

[email protected] seems to have a much lower MSRV, so that could at least be used, to get rid of the warning

@danielhenrymantilla
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
K-feature Kind: proposed new code to implement new behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants