Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wallet ids and use client pubkeys #258

Open
im-adithya opened this issue Feb 4, 2025 · 1 comment
Open

Remove wallet ids and use client pubkeys #258

im-adithya opened this issue Feb 4, 2025 · 1 comment

Comments

@im-adithya
Copy link
Member

Also includes moving to /:pubkey/settings etc. routes so we don't do stuff like fetching selectedWalletId from the store in each screen.

This would also help in eliminating the case where the same connection string is added multiple times and mainly the instances where wallet ids are decremented by 1 on deleting a wallet, which looks very bad.

@rolznz
Copy link
Contributor

rolznz commented Feb 5, 2025

The reason to use ids is so we can easily find out which wallets in storage we know about. Is there a better way to do it? a key that has a list of wallet pubkeys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants